Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Issue 2385123004: Fix build error in headless_web_contents_impl.cc (Closed)

Created:
4 years, 2 months ago by fwang
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build error in headless_web_contents_impl.cc e2df1d707cc2a7ba4a5b49f5f1f6be249ff05baf adds a new parameter to WebContentsDelegate::WebContentsCreated. This CL updates the implementation in headless_web_contents_impl.cc accordingly. BUG=649855 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a00c95e20ede74fb518518fd45c50136c972db57 Cr-Commit-Position: refs/heads/master@{#422745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
fwang
4 years, 2 months ago (2016-10-04 10:14:25 UTC) #3
fwang
4 years, 2 months ago (2016-10-04 10:14:41 UTC) #4
alex clarke (OOO till 29th)
lgtm
4 years, 2 months ago (2016-10-04 10:37:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385123004/1
4 years, 2 months ago (2016-10-04 10:38:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 10:46:30 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a00c95e20ede74fb518518fd45c50136c972db57 Cr-Commit-Position: refs/heads/master@{#422745}
4 years, 2 months ago (2016-10-04 10:49:31 UTC) #12
nasko
Is headless not compiled as part of any target? I didn't see any breakage, the ...
4 years, 2 months ago (2016-10-04 23:02:01 UTC) #14
fwang
On 2016/10/04 23:02:01, nasko (slow) wrote: > Is headless not compiled as part of any ...
4 years, 2 months ago (2016-10-05 06:28:15 UTC) #15
alex clarke (OOO till 29th)
4 years, 2 months ago (2016-10-05 09:05:20 UTC) #16
Message was sent while issue was closed.
On 2016/10/04 23:02:01, nasko (slow) wrote:
> Is headless not compiled as part of any target? I didn't see any breakage, the
> CQ allowed the CL to go through, and I don't think the tree was closed.

Headless will be on the waterfall before long:
https://bugs.chromium.org/p/chromium/issues/detail?id=632008&desc=2

Powered by Google App Engine
This is Rietveld 408576698