Enable VR Shell for release build too

Enable VR Shell for release build too

Vr Shell was disabled in release build regardless if enable_vr_shell is set
or not. The reason was proguard obfuscated the name we use in VrShellDelegate
This adds rules to prevent obfuscation.

BUG=652340
Committed: https://crrev.com/823aa13816cbf9df2062089959615f6eb71b4daa
Cr-Commit-Position: refs/heads/master@{#422940}

[bshe, 2016-10-03 17:47:33]

bshe@chromium.org changed reviewers:
+ agrieve@chromium.org, mthiesse@chromium.org

[bshe, 2016-10-03 17:47:33]

Hi Andrew and Micheal. 

Do you mind to take a look at this CL?

Thanks!

[mthiesse, 2016-10-03 17:57:21]

Please disable the VR Shell menu item before enabling VR Shell for release
builds - this was intended as a debug only feature to be removed at release.

The relevant line is here:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

I would recommend putting it behind a CommandLine.hasSwitch check, for some flag
along the lines of 'vrshell-debug'

[agrieve, 2016-10-03 18:17:47]

proguard changes lgtm

[mthiesse, 2016-10-03 20:38:30]

There are probably also a whole bunch of other issues that should be resolved
before setting this flag.

One more off the top of my head is that we need to un-integrate with the
daydream launcher, as we don't support cold-starts from the daydream launcher
and until that's fixed it'll be a really bad experience.

[bshe, 2016-10-03 20:39:06]

On 2016/10/03 17:57:21, mthiesse wrote:
> Please disable the VR Shell menu item before enabling VR Shell for release
> builds - this was intended as a debug only feature to be removed at release.
> 
> The relevant line is here:
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> 
> I would recommend putting it behind a CommandLine.hasSwitch check, for some
flag
> along the lines of 'vrshell-debug'
This could be in a separate CL? I am not enabling vr shell by default in this
CL. Just want to fix the behavior difference of release and debug build after
enable_vr_shell is enabled manually.

[bshe, 2016-10-03 20:40:04]

bshe@chromium.org changed reviewers:
+ dtrainor@chromium.org

[bshe, 2016-10-03 20:40:04]

+dtrainor for VrShell.java file
Thanks

[mthiesse, 2016-10-03 20:41:21]

Ah, okay if this isn't changing the default then lgtm.

[David Trainor- moved to gerrit, 2016-10-04 20:16:08]

lgtm

[bshe, 2016-10-04 20:30:13]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:30:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 21:38:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 21:41:20]

Description was changed from

==========
Enable VR Shell for release build too

Vr Shell was disabled in release build regardless if enable_vr_shell is set
or not. The reason was proguard obfuscated the name we use in VrShellDelegate
This adds rules to prevent obfuscation.


BUG=652340
==========

to

==========
Enable VR Shell for release build too

Vr Shell was disabled in release build regardless if enable_vr_shell is set
or not. The reason was proguard obfuscated the name we use in VrShellDelegate
This adds rules to prevent obfuscation.

BUG=652340

Committed: https://crrev.com/823aa13816cbf9df2062089959615f6eb71b4daa
Cr-Commit-Position: refs/heads/master@{#422940}
==========

[commit-bot: I haz the power, 2016-10-04 21:41:21]

Patchset 1 (id:??) landed as
https://crrev.com/823aa13816cbf9df2062089959615f6eb71b4daa
Cr-Commit-Position: refs/heads/master@{#422940}