Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2385113002: TEST: Don't check node id and volume value at initialization response

Created:
4 years, 2 months ago by hychao
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TEST: Don't check node id and volume value at initialization response CrasAudioHandler calls InitializeAudioState() twice on power up sending 2 dbus messages to set output volume. However we are not sure about the order of the 2nd message being sent and the 1st response being received. In the case that the 1st response is received after the 2nd message is sent, if we check the node id and volume against the latest cached values, this check could fail and reset the initialization flag, causing the 2nd response to trigger volume bar pop up on UI. BUG=649360

Patch Set 1 #

Patch Set 2 : Add new mic types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chromeos/audio/audio_device.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chromeos/audio/audio_device.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698