chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h - Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length. (Closed)

Patch Set: Fix unittest. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc » ('j') | chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

diff --git a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

index 7cf00d26eab5bc28c3392404a7efc4217a1fd00b..7740391d4d43da57a1ec31ae0f1b8b4d38c177ab 100644

--- a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

+++ b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERVER_H_

#include "base/memory/weak_ptr.h"

+#include "base/time/time.h"

#include "chrome/browser/ui/browser_list_observer.h"

namespace metrics {

@@ -18,7 +19,7 @@ class ChromeVisibilityObserver : public chrome::BrowserListObserver {

protected:

// Notifies |DesktopSessionDurationTracker| of visibility changes. Overridden

// by tests.

- virtual void SendVisibilityChangeEvent(bool active);

+ virtual void SendVisibilityChangeEvent(bool active, base::TimeDelta time_ago);

private:

// Cancels visibility change in case when the browser becomes visible after a