Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length. (Closed)
Patch Set: Address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERV ER_H_ 5 #ifndef CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERV ER_H_
6 #define CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERV ER_H_ 6 #define CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERV ER_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "base/time/time.h"
9 #include "chrome/browser/ui/browser_list_observer.h" 10 #include "chrome/browser/ui/browser_list_observer.h"
10 11
11 namespace metrics { 12 namespace metrics {
12 // Observer for tracking browser visibility events. 13 // Observer for tracking browser visibility events.
13 class ChromeVisibilityObserver : public chrome::BrowserListObserver { 14 class ChromeVisibilityObserver : public chrome::BrowserListObserver {
14 public: 15 public:
15 ChromeVisibilityObserver(); 16 ChromeVisibilityObserver();
16 ~ChromeVisibilityObserver() override; 17 ~ChromeVisibilityObserver() override;
17 18
18 protected: 19 protected:
19 // Notifies |DesktopSessionDurationTracker| of visibility changes. Overridden 20 // Notifies |DesktopSessionDurationTracker| of visibility changes. Overridden
20 // by tests. 21 // by tests.
21 virtual void SendVisibilityChangeEvent(bool active); 22 virtual void SendVisibilityChangeEvent(bool active, base::TimeDelta time_ago);
22 23
23 private: 24 private:
24 // Cancels visibility change in case when the browser becomes visible after a 25 // Cancels visibility change in case when the browser becomes visible after a
25 // short gap. 26 // short gap.
26 void CancelVisibilityChange(); 27 void CancelVisibilityChange();
27 28
28 // chrome::BrowserListObserver: 29 // chrome::BrowserListObserver:
29 void OnBrowserSetLastActive(Browser* browser) override; 30 void OnBrowserSetLastActive(Browser* browser) override;
30 void OnBrowserNoLongerActive(Browser* browser) override; 31 void OnBrowserNoLongerActive(Browser* browser) override;
31 void OnBrowserRemoved(Browser* browser) override; 32 void OnBrowserRemoved(Browser* browser) override;
32 33
33 // Sets |visibility_gap_timeout_| based on variation params. 34 // Sets |visibility_gap_timeout_| based on variation params.
34 void InitVisibilityGapTimeout(); 35 void InitVisibilityGapTimeout();
35 36
36 // Timeout interval for waiting after loss of visibility. This allows merging 37 // Timeout interval for waiting after loss of visibility. This allows merging
37 // two visibility session if they happened very shortly after each other, for 38 // two visibility session if they happened very shortly after each other, for
38 // example, when user switching between two browser windows. 39 // example, when user switching between two browser windows.
39 base::TimeDelta visibility_gap_timeout_; 40 base::TimeDelta visibility_gap_timeout_;
40 41
41 base::WeakPtrFactory<ChromeVisibilityObserver> weak_factory_; 42 base::WeakPtrFactory<ChromeVisibilityObserver> weak_factory_;
42 43
43 DISALLOW_COPY_AND_ASSIGN(ChromeVisibilityObserver); 44 DISALLOW_COPY_AND_ASSIGN(ChromeVisibilityObserver);
44 }; 45 };
45 46
46 } // namespace metrics 47 } // namespace metrics
47 48
48 #endif // CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBS ERVER_H_ 49 #endif // CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBS ERVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698