Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 2385103002: Deprecate StaleWhileRevalidateMetricsObserver (Closed)
Patch Set: build rule Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
deleted file mode 100644
index 88012dae64b7b329227e807914cdd2c8314a7c70..0000000000000000000000000000000000000000
--- a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
+++ /dev/null
@@ -1,53 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h"
-
-#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
-#include "chrome/common/page_load_metrics/page_load_timing.h"
-#include "content/public/browser/navigation_handle.h"
-#include "net/base/stale_while_revalidate_experiment_domains.h"
-
-namespace chrome {
-
-StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver() {}
-
-page_load_metrics::PageLoadMetricsObserver::ObservePolicy
-StaleWhileRevalidateMetricsObserver::OnCommit(
- content::NavigationHandle* navigation_handle) {
- return net::IsHostInStaleWhileRevalidateExperimentDomain(
- navigation_handle->GetURL().host())
- ? CONTINUE_OBSERVING
- : STOP_OBSERVING;
-}
-
-void StaleWhileRevalidateMetricsObserver::OnComplete(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& extra_info) {
- using page_load_metrics::WasStartedInForegroundOptionalEventInForeground;
-
- if (WasStartedInForegroundOptionalEventInForeground(timing.load_event_start,
- extra_info)) {
- PAGE_LOAD_HISTOGRAM(
- "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
- "NavigationToLoadEventFired",
- timing.load_event_start.value());
- }
- if (WasStartedInForegroundOptionalEventInForeground(timing.first_layout,
- extra_info)) {
- PAGE_LOAD_HISTOGRAM(
- "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
- "NavigationToFirstLayout",
- timing.first_layout.value());
- }
- if (WasStartedInForegroundOptionalEventInForeground(timing.first_text_paint,
- extra_info)) {
- PAGE_LOAD_HISTOGRAM(
- "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
- "NavigationToFirstTextPaint",
- timing.first_text_paint.value());
- }
-}
-
-} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698