Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 23851028: MIPS: Improve code generation for the HRandom instruction. (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/lithium-mips.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1606 matching lines...) Expand 10 before | Expand all | Expand 10 after
1617 LPower* result = new(zone()) LPower(left, right); 1617 LPower* result = new(zone()) LPower(left, right);
1618 return MarkAsCall(DefineFixedDouble(result, f0), 1618 return MarkAsCall(DefineFixedDouble(result, f0),
1619 instr, 1619 instr,
1620 CAN_DEOPTIMIZE_EAGERLY); 1620 CAN_DEOPTIMIZE_EAGERLY);
1621 } 1621 }
1622 1622
1623 1623
1624 LInstruction* LChunkBuilder::DoRandom(HRandom* instr) { 1624 LInstruction* LChunkBuilder::DoRandom(HRandom* instr) {
1625 ASSERT(instr->representation().IsDouble()); 1625 ASSERT(instr->representation().IsDouble());
1626 ASSERT(instr->global_object()->representation().IsTagged()); 1626 ASSERT(instr->global_object()->representation().IsTagged());
1627 LOperand* global_object = UseFixed(instr->global_object(), a0); 1627 LOperand* global_object = UseTempRegister(instr->global_object());
1628 LRandom* result = new(zone()) LRandom(global_object); 1628 LOperand* scratch = TempRegister();
1629 return MarkAsCall(DefineFixedDouble(result, f0), instr); 1629 LOperand* scratch2 = TempRegister();
1630 LOperand* scratch3 = TempRegister();
1631 LRandom* result = new(zone()) LRandom(
1632 global_object, scratch, scratch2, scratch3);
1633 return DefineFixedDouble(result, f0);
1630 } 1634 }
1631 1635
1632 1636
1633 LInstruction* LChunkBuilder::DoCompareGeneric(HCompareGeneric* instr) { 1637 LInstruction* LChunkBuilder::DoCompareGeneric(HCompareGeneric* instr) {
1634 ASSERT(instr->left()->representation().IsTagged()); 1638 ASSERT(instr->left()->representation().IsTagged());
1635 ASSERT(instr->right()->representation().IsTagged()); 1639 ASSERT(instr->right()->representation().IsTagged());
1636 LOperand* left = UseFixed(instr->left(), a1); 1640 LOperand* left = UseFixed(instr->left(), a1);
1637 LOperand* right = UseFixed(instr->right(), a0); 1641 LOperand* right = UseFixed(instr->right(), a0);
1638 LCmpT* result = new(zone()) LCmpT(left, right); 1642 LCmpT* result = new(zone()) LCmpT(left, right);
1639 return MarkAsCall(DefineFixed(result, v0), instr); 1643 return MarkAsCall(DefineFixed(result, v0), instr);
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
2522 2526
2523 2527
2524 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2528 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2525 LOperand* object = UseRegister(instr->object()); 2529 LOperand* object = UseRegister(instr->object());
2526 LOperand* index = UseRegister(instr->index()); 2530 LOperand* index = UseRegister(instr->index());
2527 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2531 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2528 } 2532 }
2529 2533
2530 2534
2531 } } // namespace v8::internal 2535 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698