Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 23851028: MIPS: Improve code generation for the HRandom instruction. (Closed)

Created:
7 years, 3 months ago by kilvadyb
Modified:
7 years, 3 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Improve code generation for the HRandom instruction. Port r16684 (e0f70aa) Original commit message: Since the per-context random number generator is now properly seeded upon context creation, we do not need to check for lazy-initialization anymore, and so we can implement the HRandom instruction w/o having to call into the C function (which means we don't need to MarkAsCall anymore). TEST=cctest/test-random BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -60 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +38 lines, -53 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +12 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 3 months ago (2013-09-12 20:44:58 UTC) #1
kisg
LGTM
7 years, 3 months ago (2013-09-12 21:06:47 UTC) #2
palfia
7 years, 3 months ago (2013-09-12 21:18:14 UTC) #3
Committed as r16695.

Powered by Google App Engine
This is Rietveld 408576698