Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm

Issue 23851016: Convert zoom callbacks to use CallbackRegistry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm
diff --git a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm
index 172056d4fbedd6272d6ff9440e69fd7266fe872f..23eb0b8b275a8629e2dd0764efb56df79ac1f5c8 100644
--- a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm
+++ b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm
@@ -66,16 +66,14 @@ class ZoomLevelObserver {
public:
ZoomLevelObserver(WrenchMenuController* controller,
content::HostZoomMap* map)
- : callback_(base::Bind(&ZoomLevelObserver::OnZoomLevelChanged,
- base::Unretained(this))),
- controller_(controller),
+ : controller_(controller),
map_(map) {
- map_->AddZoomLevelChangedCallback(callback_);
+ subscription_ = map_->AddZoomLevelChangedCallback(
+ base::Bind(&ZoomLevelObserver::OnZoomLevelChanged,
+ base::Unretained(this)));
}
- ~ZoomLevelObserver() {
- map_->RemoveZoomLevelChangedCallback(callback_);
- }
+ ~ZoomLevelObserver() {}
private:
void OnZoomLevelChanged(const HostZoomMap::ZoomLevelChange& change) {
@@ -86,7 +84,7 @@ class ZoomLevelObserver {
[[controller_ zoomDisplay] setTitle:SysUTF16ToNSString(level)];
}
- content::HostZoomMap::ZoomLevelChangedCallback callback_;
+ scoped_ptr<content::HostZoomMap::Subscription> subscription_;
WrenchMenuController* controller_; // Weak; owns this.
content::HostZoomMap* map_; // Weak.
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698