Issue 23851008: Added cache flush on network change to ServiceDiscoveryHostClient

Issue 23851008: Added cache flush on network change to ServiceDiscoveryHostClient (Closed)

Created:
7 years, 3 months ago by Noam Samuel

Modified:
7 years, 3 months ago

Reviewers:
vitalybuka_at_gmail, gene, Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added cache flush on network change to ServiceDiscoveryHostClient ServiceDiscoveryHostClient now listens for IP address changes (and, by extension, sleep/wake) and flushes the cache and resets the utility process. BUG=284673 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221914

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : Changed to invalidate all objects #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -29 lines)			Patch
M	chrome/browser/local_discovery/privet_device_lister.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_device_lister_impl.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_device_lister_impl.cc	View	1 2	3 chunks	+19 lines, -6 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_device_lister_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_notifications.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_notifications.cc	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_host_client.h	View	1 2	4 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_host_client.cc	View	1 2 3 4	4 chunks	+26 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/local_discovery/local_discovery.js	View	1	3 chunks	+26 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/common/local_discovery/service_discovery_client.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/utility/local_discovery/service_discovery_message_handler.cc	View	1 2	3 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

we can do this in less complicated way 1. Reset utility process with special message ...

7 years, 3 months ago (2013-09-06 04:59:27 UTC) #2

Noam Samuel

On 2013/09/06 04:59:27, Vitaly Buka wrote: > we can do this in less complicated way ...

7 years, 3 months ago (2013-09-07 00:05:00 UTC) #3

Vitaly Buka (NO REVIEWS)

lgtm https://codereview.chromium.org/23851008/diff/16001/chrome/browser/local_discovery/service_discovery_host_client.cc File chrome/browser/local_discovery/service_discovery_host_client.cc (right): https://codereview.chromium.org/23851008/diff/16001/chrome/browser/local_discovery/service_discovery_host_client.cc#newcode292 chrome/browser/local_discovery/service_discovery_host_client.cc:292: i != service_watcher_callbacks.end();) { I see no reason ...

7 years, 3 months ago (2013-09-07 00:27:50 UTC) #4

Noam Samuel

https://codereview.chromium.org/23851008/diff/16001/chrome/browser/local_discovery/service_discovery_host_client.cc File chrome/browser/local_discovery/service_discovery_host_client.cc (right): https://codereview.chromium.org/23851008/diff/16001/chrome/browser/local_discovery/service_discovery_host_client.cc#newcode292 chrome/browser/local_discovery/service_discovery_host_client.cc:292: i != service_watcher_callbacks.end();) { On 2013/09/07 00:27:51, Vitaly Buka ...

7 years, 3 months ago (2013-09-07 01:34:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23851008/30001

7 years, 3 months ago (2013-09-07 01:35:11 UTC) #6

commit-bot: I haz the power

Failed to apply patch for chrome/browser/resources/local_discovery/local_discovery.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 3 months ago (2013-09-07 01:35:17 UTC) #7

Failed to apply patch for
chrome/browser/resources/local_discovery/local_discovery.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/local_discovery/local_discovery.js
  Hunk #1 FAILED at 207.
  Hunk #2 succeeded at 22 with fuzz 2 (offset -226 lines).
  Hunk #3 FAILED at 354.
  2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/resources/local_discovery/local_discovery.js.rej

Patch:       chrome/browser/resources/local_discovery/local_discovery.js
Index: chrome/browser/resources/local_discovery/local_discovery.js
diff --git a/chrome/browser/resources/local_discovery/local_discovery.js
b/chrome/browser/resources/local_discovery/local_discovery.js
index
4ec0c33a9eb77098f4d9273dc06c55e48a5f7dec..6ff4865f9fffb2eb7274cbc37cbc6a892f14b774
100644
--- a/chrome/browser/resources/local_discovery/local_discovery.js
+++ b/chrome/browser/resources/local_discovery/local_discovery.js
@@ -207,17 +207,7 @@ cr.define('local_discovery', function() {
       }
     }
 
-    var numberPrinters = $('register-device-list').children.length;
-    $('printer-num').textContent = generateNumberPrintersAvailableText(
-      numberPrinters);
-
-    if (numberPrinters == 0) {
-      $('register-message').textContent = loadTimeData.getString(
-        'noPrintersOnNetworkExplanation');
-    } else {
-      $('register-message').textContent = loadTimeData.getString(
-        'registerConfirmMessage');
-    }
+    updateUIToReflectNumberOfLocalDevices();
   }
 
   /**
@@ -248,6 +238,29 @@ cr.define('local_discovery', function() {
     }
   }
 
+  function onDeviceCacheFlushed() {
+    for (var deviceName in devices) {
+      devices[deviceName].removeDevice();
+      delete devices[deviceName];
+    }
+
+    updateUIToReflectNumberOfLocalDevices();
+  }
+
+  function updateUIToReflectNumberOfLocalDevices() {
+    var numberPrinters = $('register-device-list').children.length;
+    $('printer-num').textContent = generateNumberPrintersAvailableText(
+      numberPrinters);
+
+    if (numberPrinters == 0) {
+      $('register-message').textContent = loadTimeData.getString(
+        'noPrintersOnNetworkExplanation');
+    } else {
+      $('register-message').textContent = loadTimeData.getString(
+        'registerConfirmMessage');
+    }
+  }
+
 
   /**
    * Announce that a registration succeeeded.
@@ -331,6 +344,7 @@ cr.define('local_discovery', function() {
     onRegistrationFailed: onRegistrationFailed,
     onUnregisteredDeviceUpdate: onUnregisteredDeviceUpdate,
     onRegistrationConfirmedOnPrinter: onRegistrationConfirmedOnPrinter,
-    onCloudDeviceListAvailable: onCloudDeviceListAvailable
+    onCloudDeviceListAvailable: onCloudDeviceListAvailable,
+    onDeviceCacheFlushed: onDeviceCacheFlushed
   };
 });

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23851008/30001

7 years, 3 months ago (2013-09-07 04:26:10 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23851008/30001

7 years, 3 months ago (2013-09-07 04:50:50 UTC) #9

Message was sent while issue was closed.

Change committed as 221914

Expand Messages | Collapse Messages