Issue 23851003: Have StyleSheetCollections constructor take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23851003: Have StyleSheetCollections constructor take a Document reference in argument (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium, dglazkov, dglazkov1

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have StyleSheetCollections constructor take a Document reference in argument Have StyleSheetCollections and StyleSheetCollection constructors take a Document reference in argument instead of a pointer since it can never be NULL. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157050

Patch Set 1 #

Patch Set 2 : Have StyleSheetCollection constructor take a Document reference as well #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -55 lines)			Patch
M	Source/core/dom/Document.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/ShadowTreeStyleSheetCollection.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/ShadowTreeStyleSheetCollection.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/StyleSheetCollection.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/StyleSheetCollection.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/StyleSheetCollections.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/StyleSheetCollections.cpp	View	1	21 chunks	+40 lines, -40 lines	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23851003/4001

7 years, 3 months ago (2013-09-01 19:05:26 UTC) #3

Message was sent while issue was closed.

Change committed as 157050

Expand Messages | Collapse Messages