Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2385073002: HTMLConstructor implementation (Closed)

Created:
4 years, 2 months ago by yurak
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented HTMLConstructor extended attribute. Specs: https://html.spec.whatwg.org/#html-element-constructors Replaced V8HTMLElementCustom with V8HTMLConstructor Add new extended attribute [HTMLConstructor] to bindings and IDLExtendedAttributes.txt Added description to IDLExtendedAttributes.md and re-organized descriptions Added checks for conflicting extended attributes with [HTMLConstructor] in v8_interface.py Edited jinja templates for [HTMLConstructor] interface Replaced [CustomConstructor] with [HTMLConstructor] in HTMLElement.idl BUG=648828 Committed: https://crrev.com/6ad512924f794cd4cbee80246106716993919bde Cr-Commit-Position: refs/heads/master@{#423068}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move V8HTMLConstructor.cpp outside of 'custom' dir, spelling error fix #

Total comments: 2

Patch Set 3 : Alphabetical order #

Patch Set 4 : Renamed V8HTMLElement constructor to HTMLConstructor #

Total comments: 1

Patch Set 5 : Renamed V8HTMLElement constructor to HTMLConstructor #

Total comments: 5

Patch Set 6 : Renamed V8HTMLElement constructor to HTMLConstructor #

Messages

Total messages: 32 (16 generated)
dominicc (has gone to gerrit)
core/html LGTM. haraken--could you take a look for bindings? yurak is working at this piece ...
4 years, 2 months ago (2016-10-03 05:50:26 UTC) #7
haraken
LGTM Have we sent an Intent-to-implement to blink-dev@? https://codereview.chromium.org/2385073002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp File third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp (right): https://codereview.chromium.org/2385073002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp#newcode22 third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp:22: void ...
4 years, 2 months ago (2016-10-03 06:13:04 UTC) #9
dominicc (has gone to gerrit)
On Mon, Oct 3, 2016 at 3:13 PM, <haraken@chromium.org> wrote: > LGTM > > Have ...
4 years, 2 months ago (2016-10-03 08:06:02 UTC) #10
dominicc (has gone to gerrit)
On Mon, Oct 3, 2016 at 3:13 PM, <haraken@chromium.org> wrote: > LGTM > > Have ...
4 years, 2 months ago (2016-10-03 08:06:03 UTC) #11
haraken
On 2016/10/03 08:06:03, dominicc wrote: > On Mon, Oct 3, 2016 at 3:13 PM, <mailto:haraken@chromium.org> ...
4 years, 2 months ago (2016-10-03 08:14:19 UTC) #12
dominicc (has gone to gerrit)
On Mon, Oct 3, 2016 at 5:14 PM, <haraken@chromium.org> wrote: > On 2016/10/03 08:06:03, dominicc ...
4 years, 2 months ago (2016-10-04 01:17:22 UTC) #13
dominicc (has gone to gerrit)
On Mon, Oct 3, 2016 at 5:14 PM, <haraken@chromium.org> wrote: > On 2016/10/03 08:06:03, dominicc ...
4 years, 2 months ago (2016-10-04 01:17:23 UTC) #14
yurak
I renamed ::create to ::HTMLConstructor. I made a few new changes to two files listed ...
4 years, 2 months ago (2016-10-04 05:37:34 UTC) #15
haraken
LGTM, assuming there's no objection on the Intent-to-implement dominicc is going to send.
4 years, 2 months ago (2016-10-04 05:38:30 UTC) #16
bashi
https://codereview.chromium.org/2385073002/diff/60001/third_party/WebKit/Source/bindings/scripts/idl_definitions.py File third_party/WebKit/Source/bindings/scripts/idl_definitions.py (right): https://codereview.chromium.org/2385073002/diff/60001/third_party/WebKit/Source/bindings/scripts/idl_definitions.py#newcode973 third_party/WebKit/Source/bindings/scripts/idl_definitions.py:973: html_constructors = [IdlOperation.constructor_from_arguments_node('HTMLConstructor', idl_name, None)] Could you help me ...
4 years, 2 months ago (2016-10-04 05:53:51 UTC) #18
yurak
On 2016/10/04 at 05:53:51, bashi wrote: > https://codereview.chromium.org/2385073002/diff/60001/third_party/WebKit/Source/bindings/scripts/idl_definitions.py > File third_party/WebKit/Source/bindings/scripts/idl_definitions.py (right): > > https://codereview.chromium.org/2385073002/diff/60001/third_party/WebKit/Source/bindings/scripts/idl_definitions.py#newcode973 ...
4 years, 2 months ago (2016-10-04 06:29:46 UTC) #19
bashi
lgtm on my side. https://codereview.chromium.org/2385073002/diff/80001/third_party/WebKit/Source/bindings/scripts/v8_interface.py File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right): https://codereview.chromium.org/2385073002/diff/80001/third_party/WebKit/Source/bindings/scripts/v8_interface.py#newcode295 third_party/WebKit/Source/bindings/scripts/v8_interface.py:295: html_constructor = 'HTMLConstructor' in extended_attributes ...
4 years, 2 months ago (2016-10-04 06:44:46 UTC) #20
Yuki
lgtm https://codereview.chromium.org/2385073002/diff/80001/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md File third_party/WebKit/Source/bindings/IDLExtendedAttributes.md (right): https://codereview.chromium.org/2385073002/diff/80001/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md#newcode303 third_party/WebKit/Source/bindings/IDLExtendedAttributes.md:303: Standard: [HTMLConstructor](https://html.spec.whatwg.org/#html-element-constructors) nit: https://html.spec.whatwg.org/multipage/dom.html#html-element-constructors Could you use "multipage" ...
4 years, 2 months ago (2016-10-04 06:51:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385073002/100001
4 years, 2 months ago (2016-10-05 01:53:40 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-05 03:47:34 UTC) #30
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 03:51:42 UTC) #32
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6ad512924f794cd4cbee80246106716993919bde
Cr-Commit-Position: refs/heads/master@{#423068}

Powered by Google App Engine
This is Rietveld 408576698