Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5598)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc

Issue 2385063005: Make PermissionRequest::GetIconId return different types (Closed)
Patch Set: android Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
index 7045b6cf219a066dae2f2932bfa0131c476846f2..1146cb87a701da2ae59c691e0155ad29fdb4825d 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
@@ -202,7 +202,6 @@ PermissionsBubbleDialogDelegateView::PermissionsBubbleDialogDelegateView(
requests[0]->GetOrigin(),
url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC);
- ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
bool show_persistence_toggle = true;
for (size_t index = 0; index < requests.size(); index++) {
DCHECK(index < accept_state.size());
@@ -224,13 +223,10 @@ PermissionsBubbleDialogDelegateView::PermissionsBubbleDialogDelegateView(
views::BoxLayout::kHorizontal, views::kCheckboxIndent, 0,
views::kItemLabelSpacing));
views::ImageView* icon = new views::ImageView();
- gfx::VectorIconId vector_id = requests[index]->GetVectorIconId();
+ gfx::VectorIconId vector_id = requests[index]->GetIconId();
if (vector_id != gfx::VectorIconId::VECTOR_ICON_NONE) {
icon->SetImage(
gfx::CreateVectorIcon(vector_id, kIconSize, gfx::kChromeIconGrey));
- } else {
- icon->SetImage(bundle.GetImageSkiaNamed(requests.at(index)->GetIconId()));
- icon->SetImageSize(gfx::Size(kIconSize, kIconSize));
}
icon->SetTooltipText(base::string16()); // Redundant with the text fragment
label_container->AddChildView(icon);

Powered by Google App Engine
This is Rietveld 408576698