Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/permissions/permission_request_manager.cc

Issue 2385063005: Make PermissionRequest::GetIconId return different types (Closed)
Patch Set: android Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_manager.cc
diff --git a/chrome/browser/permissions/permission_request_manager.cc b/chrome/browser/permissions/permission_request_manager.cc
index 19d67cfc7acbf04645a87a951b6d16143be8b04e..40fdb5031c0ea5d498ea63f9a43a18bbf4cc2ba6 100644
--- a/chrome/browser/permissions/permission_request_manager.cc
+++ b/chrome/browser/permissions/permission_request_manager.cc
@@ -27,7 +27,7 @@ class CancelledRequest : public PermissionRequest {
origin_(cancelled->GetOrigin()) {}
~CancelledRequest() override {}
- int GetIconId() const override { return icon_; }
+ IconId GetIconId() const override { return icon_; }
base::string16 GetMessageTextFragment() const override {
return message_fragment_;
}
@@ -41,7 +41,7 @@ class CancelledRequest : public PermissionRequest {
void RequestFinished() override { delete this; }
private:
- int icon_;
+ IconId icon_;
base::string16 message_fragment_;
GURL origin_;
};

Powered by Google App Engine
This is Rietveld 408576698