In run_webkit_tests, use host.environ to access gtest shard env vars.

In run_webkit_tests, use host.environ to access gtest shard env vars.

Reason: if we access environment variables via the Host object, then
it's easier to test without affecting real environment variables in
the unit tests, so the unit test methods can be simplified.

Committed: https://crrev.com/6b7cefb7e2c3a5b3cfcad875e46e5df8256cb0ec
Cr-Commit-Position: refs/heads/master@{#422486}

[qyearsley, 2016-10-02 18:34:03]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2016-10-02 18:34:03]

This is a follow-up to http://crrev.com/2350853003

[jeffcarp, 2016-10-03 17:27:40]

On 2016/10/02 at 18:34:03, qyearsley wrote:
> This is a follow-up to http://crrev.com/2350853003

this is great, thanks! lgtm

[jeffcarp, 2016-10-03 17:27:48]

https://codereview.chromium.org/2385043002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
(left):

https://codereview.chromium.org/2385043002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:257:
os.environ["WEBKIT_TEST_MAX_LOCKED_SHARDS"] =
save_env_webkit_test_max_locked_shards
Is the above no longer necessary?

[qyearsley, 2016-10-03 18:29:51]

https://codereview.chromium.org/2385043002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
(left):

https://codereview.chromium.org/2385043002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:257:
os.environ["WEBKIT_TEST_MAX_LOCKED_SHARDS"] =
save_env_webkit_test_max_locked_shards
On 2016/10/03 at 17:27:48, jeffcarp wrote:
> Is the above no longer necessary?

Nope, I believe not -- since by default, the environ of MockHost is empty or
nearly empty and so doesn't include WEBKIT_TEST_MAX_LOCKED_SHARDS, and the
purpose of this test method is to test the default behavior if that environment
variable is not set.

Saving, deleting and resetting the environment variable was necessary to make
the test non-flaky before because the test used the real set of environment
variables.

[qyearsley, 2016-10-03 18:29:53]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:30:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:18:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-03 19:20:22]

Description was changed from

==========
In run_webkit_tests, use host.environ to access gtest shard env vars.

Reason: if we access environment variables via the Host object, then
it's easier to test without affecting real environment variables in
the unit tests, so the unit test methods can be simplified.
==========

to

==========
In run_webkit_tests, use host.environ to access gtest shard env vars.

Reason: if we access environment variables via the Host object, then
it's easier to test without affecting real environment variables in
the unit tests, so the unit test methods can be simplified.

Committed: https://crrev.com/6b7cefb7e2c3a5b3cfcad875e46e5df8256cb0ec
Cr-Commit-Position: refs/heads/master@{#422486}
==========

[commit-bot: I haz the power, 2016-10-03 19:20:23]

Patchset 1 (id:??) landed as
https://crrev.com/6b7cefb7e2c3a5b3cfcad875e46e5df8256cb0ec
Cr-Commit-Position: refs/heads/master@{#422486}