Remove stl_util's deletion functions from net/url_request/.

Remove stl_util's deletion functions from net/url_request/.

BUG=555865
Committed: https://crrev.com/e26ffff3fab1b525479daf9986cde96fc88fad07
Cr-Commit-Position: refs/heads/master@{#422888}

[Avi (use Gerrit), 2016-10-02 00:21:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 00:21:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 01:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 01:12:47]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-02 02:32:29]

avi@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2016-10-03 16:01:39]

https://codereview.chromium.org/2385003002/diff/1/net/url_request/report_send...
File net/url_request/report_sender.cc (right):

https://codereview.chromium.org/2385003002/diff/1/net/url_request/report_send...
net/url_request/report_sender.cc:81: inflight_requests_.erase(it);
I should have noticed this for the other CL, but if we're doing this, the
std::set is buying us nothing but overhead. It'd be strictly better to use a
std::vector of unique_ptr.

These can also potentially trigger one per URLRequest so I'm not very
comfortable with it being O(N). This is actually a really common pattern where
one object owns a bunch of jobs and drops them when completed. I think it would
be good to just write a base::OwnedSet<T> and use that. (Or maybe some linked
list thing? That would actually be a more efficient structure.)

[Avi (use Gerrit), 2016-10-03 16:27:25]

https://codereview.chromium.org/2385003002/diff/1/net/url_request/report_send...
File net/url_request/report_sender.cc (right):

https://codereview.chromium.org/2385003002/diff/1/net/url_request/report_send...
net/url_request/report_sender.cc:81: inflight_requests_.erase(it);
On 2016/10/03 16:01:38, davidben wrote:
> I should have noticed this for the other CL, but if we're doing this, the
> std::set is buying us nothing but overhead. It'd be strictly better to use a
> std::vector of unique_ptr.
> 
> These can also potentially trigger one per URLRequest so I'm not very
> comfortable with it being O(N). This is actually a really common pattern where
> one object owns a bunch of jobs and drops them when completed. I think it
would
> be good to just write a base::OwnedSet<T> and use that. (Or maybe some linked
> list thing? That would actually be a more efficient structure.)

If we're talking efficiency, linked lists and sets are bad. They guarantee a
cache miss for every access, so that even an O(n) access into a vector is better
performing than an "O(log n)" access that has zero memory locality.

sets of owned objects are kinda broken in C++11 anyway, so I would be super
happy to swap in a vector here.

[Avi (use Gerrit), 2016-10-03 18:47:36]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:48:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:37:42]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-04 16:01:22]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-10-04 16:01:43]

David, I switched to a map. Please take a look.

[commit-bot: I haz the power, 2016-10-04 16:02:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:10:50]

Dry run: This issue passed the CQ dry run.

[davidben, 2016-10-04 18:04:33]

lgtm. (Sorry, didn't have time to follow-up yesterday. I could buy a vector
would even be better and I think I'd be fine with that too, but it's nice that
this way we don't have to think about it.)

[Avi (use Gerrit), 2016-10-04 19:35:08]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:35:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 19:42:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 19:44:40]

Description was changed from

==========
Remove stl_util's deletion functions from net/url_request/.

BUG=555865
==========

to

==========
Remove stl_util's deletion functions from net/url_request/.

BUG=555865

Committed: https://crrev.com/e26ffff3fab1b525479daf9986cde96fc88fad07
Cr-Commit-Position: refs/heads/master@{#422888}
==========

[commit-bot: I haz the power, 2016-10-04 19:44:42]

Patchset 3 (id:??) landed as
https://crrev.com/e26ffff3fab1b525479daf9986cde96fc88fad07
Cr-Commit-Position: refs/heads/master@{#422888}