Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2585)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2384953003: Android: Avoid linking with --gc-sections. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 5fcc050b1741aacfeebd2a964c30ec32f1460e4b..8d2acbde4c99cff87d012f534f3c7ea8e7af17a4 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1371,10 +1371,6 @@ config("no_optimize") {
"-fdata-sections",
agrieve 2016/10/03 18:34:17 Would it make sense to also remove -fdata-sections
Lei Zhang 2016/10/03 20:45:50 Done.
"-ffunction-sections",
]
-
- # Don't use gc-sections since it can cause links to succeed when they
- # actually shouldn't. http://crbug.com/159847
- ldflags = common_optimize_on_ldflags - [ "-Wl,--gc-sections" ]
} else {
cflags = [ "-O0" ]
ldflags = []
« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698