Trim more unneeded stuff from Blink's C++ style checker script.

Trim more unneeded stuff from Blink's C++ style checker script.

This formatting is enforced by the clang-format check, so there's no
need to try to enforce it with regex that try to parse C++.

BUG=none

Committed: https://crrev.com/ad6db10fac0e0a689b91f72a4f34250098584ccc
Cr-Commit-Position: refs/heads/master@{#422328}

[dcheng, 2016-10-01 07:48:37]

dcheng@chromium.org changed reviewers:
+ esprehn@chromium.org, thakis@chromium.org

[dcheng, 2016-10-01 07:48:37]

For whoever sees this first =)

Trims check-webkit-style running time across most (all?) of Blink source from
5m18s to 4m33s or so on my vm instance.

[Nico, 2016-10-01 16:39:46]

lgtm

https://codereview.chromium.org/2384943002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2384943002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:1790: 'Semicolon
defining empty statement for this loop. Use { } instead.')
I think this is caught by a compiler warning too

[dcheng, 2016-10-01 19:48:04]

https://codereview.chromium.org/2384943002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2384943002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:1790: 'Semicolon
defining empty statement for this loop. Use { } instead.')
On 2016/10/01 16:39:46, Nico (mostly away until Oct 3) wrote:
> I think this is caught by a compiler warning too

At least in a simple test, I wasn't able to get this warning to fire.

[dcheng, 2016-10-01 19:48:49]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-01 19:49:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 20:34:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-01 20:35:51]

Description was changed from

==========
Trim more unneeded stuff from Blink's C++ style checker script.

This formatting is enforced by the clang-format check, so there's no
need to try to enforce it with regex that try to parse C++.

BUG=none
==========

to

==========
Trim more unneeded stuff from Blink's C++ style checker script.

This formatting is enforced by the clang-format check, so there's no
need to try to enforce it with regex that try to parse C++.

BUG=none

Committed: https://crrev.com/ad6db10fac0e0a689b91f72a4f34250098584ccc
Cr-Commit-Position: refs/heads/master@{#422328}
==========

[commit-bot: I haz the power, 2016-10-01 20:35:52]

Patchset 3 (id:??) landed as
https://crrev.com/ad6db10fac0e0a689b91f72a4f34250098584ccc
Cr-Commit-Position: refs/heads/master@{#422328}

[Nico, 2016-10-03 18:11:17]

https://codereview.chromium.org/2384943002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2384943002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:1790: 'Semicolon
defining empty statement for this loop. Use { } instead.')
On 2016/10/01 19:48:04, dcheng wrote:
> On 2016/10/01 16:39:46, Nico (mostly away until Oct 3) wrote:
> > I think this is caught by a compiler warning too
> 
> At least in a simple test, I wasn't able to get this warning to fire.

It only fires when it's actively buggy:

tthakis@thakis:~/src/chrome/src$ cat test.cc
void f() {
  if (1);

  if (2)
    ;

  if (3); {
  }
}
thakis@thakis:~/src/chrome/src$ third_party/llvm-build/Release+Asserts/bin/clang
-c test.cc
test.cc:2:9: warning: if statement has empty body [-Wempty-body]
  if (1);
        ^
test.cc:2:9: note: put the semicolon on a separate line to silence this warning
test.cc:7:9: warning: if statement has empty body [-Wempty-body]
  if (3); {
        ^
test.cc:7:9: note: put the semicolon on a separate line to silence this warning
2 warnings generated.



Not sure if check-webkit-style needs to be stricter than that, but you're right,
the compiler does less than what this script does.