PVer4: Test checksum on startup outside the hotpath of DB load

components/safe_browsing_db/v4_store_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
@@ skipping 782 matching lines @@
   // \xb2m\x0e\xe0\xe7\xe9P9\x9b\x1cB"\xf5\xde\x05\xe0d%\xb4\xc9\x95\xe9"
 
   HashPrefixMap prefix_map_old;
   EXPECT_EQ(APPLY_UPDATE_SUCCESS,
             V4Store::AddUnlumpedHashes(4, "2222", &prefix_map_old));
   EXPECT_EQ(CHECKSUM_MISMATCH_FAILURE,
             V4Store(task_runner_, store_path_)
                 .MergeUpdate(prefix_map_old, HashPrefixMap(), nullptr, "aawc"));
 }
 
+TEST_F(V4StoreTest, TestChecksumErrorOnStartup) {
+  ListUpdateResponse list_update_response;
+  list_update_response.set_new_client_state("test_client_state");
+  list_update_response.set_platform_type(LINUX_PLATFORM);
+  list_update_response.set_response_type(ListUpdateResponse::FULL_UPDATE);
+  list_update_response.mutable_checksum()->set_sha256(
+      std::string(crypto::kSHA256Length, 0));
+  WriteFileFormatProtoToFile(0x600D71FE, 9, &list_update_response);
+  V4Store store(task_runner_, store_path_);
+  EXPECT_TRUE(store.expected_checksum_.empty());
+
+  EXPECT_EQ(READ_SUCCESS, store.ReadFromDisk());
+  EXPECT_TRUE(!store.expected_checksum_.empty());
+  EXPECT_EQ("test_client_state", store.state());
+
+  EXPECT_FALSE(store.VerifyChecksum());
+  // The database schedules the checksum verification.

[Nathan Parker, 2016/10/07 23:24:29]

Is there a database here? I'm confused by the comment.

I think you need a case where the checksum returns true, ya?

[vakh (use Gerrit instead), 2016/10/10 17:42:34]

Done.

+}
+
 }  // namespace safe_browsing