Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3075)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fxge/dib/fx_dib_engine_unittest.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Remove ScopedDict typedefs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fpdfapi/fpdf_parser/cpdf_parser.cpp ('K') | « core/fpdfdoc/cpdf_formfield.cpp ('k') | fpdfsdk/fpdfdoc_unittest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxge/dib/fx_dib_engine_unittest.cpp
diff --git a/core/fxge/dib/fx_dib_engine_unittest.cpp b/core/fxge/dib/fx_dib_engine_unittest.cpp
index b7c79c390a2dab2965a189004b21e3e44935a018..eca87c14d8e292000dee9139ef8a2db8b3fbf039 100644
--- a/core/fxge/dib/fx_dib_engine_unittest.cpp
+++ b/core/fxge/dib/fx_dib_engine_unittest.cpp
@@ -15,11 +15,10 @@
TEST(CStretchEngine, OverflowInCtor) {
FX_RECT clip_rect;
- std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> dict_obj(
- new CPDF_Dictionary());
+ std::unique_ptr<CPDF_Dictionary> dict_obj(new CPDF_Dictionary());
Lei Zhang 2016/10/03 21:50:47 Want to start using MakeUnique?
Tom Sepez 2016/10/05 21:03:02 Done here, other places will wait.
dict_obj->SetFor("Width", new CPDF_Number(71000));
dict_obj->SetFor("Height", new CPDF_Number(12500));
- std::unique_ptr<CPDF_Stream, ReleaseDeleter<CPDF_Stream>> stream(
+ std::unique_ptr<CPDF_Stream> stream(
new CPDF_Stream(nullptr, 0, dict_obj.release()));
CPDF_DIBSource dib_source;
dib_source.Load(nullptr, stream.get(), nullptr, nullptr, nullptr, nullptr,
« core/fpdfapi/fpdf_parser/cpdf_parser.cpp ('K') | « core/fpdfdoc/cpdf_formfield.cpp ('k') | fpdfsdk/fpdfdoc_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698