core/fpdfapi/fpdf_parser/cfdf_document.cpp - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cfdf_document.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: Remove ScopedDict typedefs Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cfdf_document.cpp

diff --git a/core/fpdfapi/fpdf_parser/cfdf_document.cpp b/core/fpdfapi/fpdf_parser/cfdf_document.cpp

index 860912ab3efbb3356010f108ca8d7f7a97d3abb5..c1ba9c98cca34b34a8226d519869999052921b50 100644

--- a/core/fpdfapi/fpdf_parser/cfdf_document.cpp

+++ b/core/fpdfapi/fpdf_parser/cfdf_document.cpp

@@ -79,7 +79,7 @@ void CFDF_Document::ParseStream(IFX_FileRead* pFile, FX_BOOL bOwnFile) {

if (CPDF_Dictionary* pMainDict =

ToDictionary(parser.GetObject(this, 0, 0, true))) {

m_pRootDict = pMainDict->GetDictFor("Root");

- pMainDict->Release();

+ delete pMainDict;

}

break;

}