core/fpdfapi/fpdf_edit/cpdf_creator.h - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/cpdf_creator.h

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: Remove ScopedDict typedefs Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/cpdf_creator.h

diff --git a/core/fpdfapi/fpdf_edit/cpdf_creator.h b/core/fpdfapi/fpdf_edit/cpdf_creator.h

index f81b043c601d5739407507d6c820edec1b253461..49b5fe5c18ae4bc48977aa7fd4b8e664e322bee9 100644

--- a/core/fpdfapi/fpdf_edit/cpdf_creator.h

+++ b/core/fpdfapi/fpdf_edit/cpdf_creator.h

@@ -94,7 +94,7 @@ class CPDF_Creator {

FX_FILESIZE m_XrefStart;

CFX_FileSizeListArray m_ObjectOffset;

CFX_ArrayTemplate<uint32_t> m_NewObjNumArray;

- std::unique_ptr<CPDF_Array, ReleaseDeleter<CPDF_Array>> m_pIDArray;

+ std::unique_ptr<CPDF_Array> m_pIDArray;

int32_t m_FileVersion;

};