core/fpdfapi/parser/cpdf_indirect_object_holder.h - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_indirect_object_holder.h

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_indirect_object_holder.h

diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.h b/core/fpdfapi/parser/cpdf_indirect_object_holder.h

index da4e942b5da73ca92fca89725e773febeebd827f..83a31535c4ada46bbaefdfb906aa2515de509bf7 100644

--- a/core/fpdfapi/parser/cpdf_indirect_object_holder.h

+++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.h

@@ -24,7 +24,7 @@ class CPDF_IndirectObjectHolder {

CPDF_Object* GetIndirectObject(uint32_t objnum) const;

CPDF_Object* GetOrParseIndirectObject(uint32_t objnum);

- void ReleaseIndirectObject(uint32_t objnum);

+ void DeleteIndirectObject(uint32_t objnum);

// Take ownership of |pObj|.

uint32_t AddIndirectObject(CPDF_Object* pObj);