core/fpdfapi/parser/cpdf_document.cpp - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_document.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_document.cpp

diff --git a/core/fpdfapi/parser/cpdf_document.cpp b/core/fpdfapi/parser/cpdf_document.cpp

index ad84a15a9751a76ef770cd24279d5c3cd83c70d5..64574047e5733cc4ebb8d2f07a6f7811d2ba849f 100644

--- a/core/fpdfapi/parser/cpdf_document.cpp

+++ b/core/fpdfapi/parser/cpdf_document.cpp

@@ -634,7 +634,7 @@ CPDF_Dictionary* CPDF_Document::CreateNewPage(int iPage) {

pDict->SetNameFor("Type", "Page");

uint32_t dwObjNum = AddIndirectObject(pDict);

if (!InsertNewPage(iPage, pDict)) {

- ReleaseIndirectObject(dwObjNum);

+ DeleteIndirectObject(dwObjNum);

return nullptr;

}

return pDict;