core/fpdfapi/page/cpdf_contentmarkitem.cpp - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_contentmarkitem.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_contentmarkitem.cpp

diff --git a/core/fpdfapi/page/cpdf_contentmarkitem.cpp b/core/fpdfapi/page/cpdf_contentmarkitem.cpp

index 507dc22d9ab39c03d55b2bfc55dd077f2f8d9583..68089efe7525b52935ff601991dc3c9600d2622e 100644

--- a/core/fpdfapi/page/cpdf_contentmarkitem.cpp

+++ b/core/fpdfapi/page/cpdf_contentmarkitem.cpp

@@ -39,7 +39,7 @@ FX_BOOL CPDF_ContentMarkItem::HasMCID() const {

}

void CPDF_ContentMarkItem::SetDirectDict(

- std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> pDict) {

+ std::unique_ptr<CPDF_Dictionary> pDict) {

m_ParamType = DirectDict;

m_pDirectDict = std::move(pDict);

}