core/fpdfapi/page/cpdf_contentmark.cpp - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_contentmark.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_contentmark.cpp

diff --git a/core/fpdfapi/page/cpdf_contentmark.cpp b/core/fpdfapi/page/cpdf_contentmark.cpp

index 4e8625b9400cd1ea680536c5230e657d25c3ab2e..f1daa7a6fc8e1b9f121b6ccf20a13e68d97fb10f 100644

--- a/core/fpdfapi/page/cpdf_contentmark.cpp

+++ b/core/fpdfapi/page/cpdf_contentmark.cpp

@@ -110,8 +110,7 @@ void CPDF_ContentMark::MarkData::AddMark(const CFX_ByteString& name,

if (pDict) {

if (bDirect) {

item.SetDirectDict(

- std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>>(

- ToDictionary(pDict->Clone())));

+ std::unique_ptr<CPDF_Dictionary>(ToDictionary(pDict->Clone())));

} else {

item.SetPropertiesDict(pDict);

}