Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: fpdfsdk/fpdfdoc_unittest.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Remove ScopedDict typedefs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/fpdf_doc.h" 5 #include "public/fpdf_doc.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "core/fpdfapi/cpdf_modulemgr.h" 10 #include "core/fpdfapi/cpdf_modulemgr.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 // Objects created will be released by the document. 81 // Objects created will be released by the document.
82 CPDF_Dictionary* obj = new CPDF_Dictionary(); 82 CPDF_Dictionary* obj = new CPDF_Dictionary();
83 info.push_back({m_pIndirectObjs->AddIndirectObject(obj), obj}); 83 info.push_back({m_pIndirectObjs->AddIndirectObject(obj), obj});
84 } 84 }
85 return info; 85 return info;
86 } 86 }
87 87
88 protected: 88 protected:
89 std::unique_ptr<CPDF_TestPdfDocument> m_pDoc; 89 std::unique_ptr<CPDF_TestPdfDocument> m_pDoc;
90 CPDF_IndirectObjectHolder* m_pIndirectObjs; 90 CPDF_IndirectObjectHolder* m_pIndirectObjs;
91 std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> m_pRootObj; 91 std::unique_ptr<CPDF_Dictionary> m_pRootObj;
92 }; 92 };
93 93
94 TEST_F(PDFDocTest, FindBookmark) { 94 TEST_F(PDFDocTest, FindBookmark) {
95 { 95 {
96 // No bookmark information. 96 // No bookmark information.
97 std::unique_ptr<unsigned short, pdfium::FreeDeleter> title = 97 std::unique_ptr<unsigned short, pdfium::FreeDeleter> title =
98 GetFPDFWideString(L""); 98 GetFPDFWideString(L"");
99 EXPECT_EQ(nullptr, FPDFBookmark_Find(m_pDoc.get(), title.get())); 99 EXPECT_EQ(nullptr, FPDFBookmark_Find(m_pDoc.get(), title.get()));
100 100
101 title = GetFPDFWideString(L"Preface"); 101 title = GetFPDFWideString(L"Preface");
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 // Title with no match. 224 // Title with no match.
225 std::unique_ptr<unsigned short, pdfium::FreeDeleter> title = 225 std::unique_ptr<unsigned short, pdfium::FreeDeleter> title =
226 GetFPDFWideString(L"Chapter 8"); 226 GetFPDFWideString(L"Chapter 8");
227 EXPECT_EQ(nullptr, FPDFBookmark_Find(m_pDoc.get(), title.get())); 227 EXPECT_EQ(nullptr, FPDFBookmark_Find(m_pDoc.get(), title.get()));
228 228
229 // Title with a match. 229 // Title with a match.
230 title = GetFPDFWideString(L"Chapter 3"); 230 title = GetFPDFWideString(L"Chapter 3");
231 EXPECT_EQ(bookmarks[3].obj, FPDFBookmark_Find(m_pDoc.get(), title.get())); 231 EXPECT_EQ(bookmarks[3].obj, FPDFBookmark_Find(m_pDoc.get(), title.get()));
232 } 232 }
233 } 233 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698