Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_stream.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Remove ScopedDict typedefs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/fpdf_parser/cpdf_stream.h" 7 #include "core/fpdfapi/fpdf_parser/cpdf_stream.h"
8 8
9 #include "core/fpdfapi/fpdf_parser/cpdf_dictionary.h" 9 #include "core/fpdfapi/fpdf_parser/cpdf_dictionary.h"
10 #include "core/fpdfapi/fpdf_parser/cpdf_stream_acc.h" 10 #include "core/fpdfapi/fpdf_parser/cpdf_stream_acc.h"
11 #include "core/fpdfapi/fpdf_parser/fpdf_parser_decode.h" 11 #include "core/fpdfapi/fpdf_parser/fpdf_parser_decode.h"
12 #include "third_party/base/numerics/safe_conversions.h" 12 #include "third_party/base/numerics/safe_conversions.h"
13 #include "third_party/base/stl_util.h" 13 #include "third_party/base/stl_util.h"
14 14
15 CPDF_Stream::CPDF_Stream() {} 15 CPDF_Stream::CPDF_Stream() {}
16 16
17 CPDF_Stream::CPDF_Stream(uint8_t* pData, uint32_t size, CPDF_Dictionary* pDict) 17 CPDF_Stream::CPDF_Stream(uint8_t* pData, uint32_t size, CPDF_Dictionary* pDict)
18 : m_pDict(pDict), 18 : m_dwSize(size), m_pDict(pDict), m_pDataBuf(pData) {}
19 m_dwSize(size),
20 m_pDataBuf(pData) {}
21 19
22 CPDF_Stream::~CPDF_Stream() { 20 CPDF_Stream::~CPDF_Stream() {
23 m_ObjNum = kInvalidObjNum; 21 m_ObjNum = kInvalidObjNum;
24 if (m_pDict && m_pDict->GetObjNum() == kInvalidObjNum) 22 if (m_pDict && m_pDict->GetObjNum() == kInvalidObjNum)
25 m_pDict.release(); // lowercase release, release ownership. 23 m_pDict.release(); // lowercase release, release ownership.
26 } 24 }
27 25
28 CPDF_Object::Type CPDF_Stream::GetType() const { 26 CPDF_Object::Type CPDF_Stream::GetType() const {
29 return STREAM; 27 return STREAM;
30 } 28 }
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 112
115 return TRUE; 113 return TRUE;
116 } 114 }
117 115
118 CFX_WideString CPDF_Stream::GetUnicodeText() const { 116 CFX_WideString CPDF_Stream::GetUnicodeText() const {
119 CPDF_StreamAcc stream; 117 CPDF_StreamAcc stream;
120 stream.LoadAllData(this, FALSE); 118 stream.LoadAllData(this, FALSE);
121 return PDF_DecodeText(stream.GetData(), stream.GetSize()); 119 return PDF_DecodeText(stream.GetData(), stream.GetSize());
122 } 120 }
123 121
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698