Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: core/fpdfapi/parser/cfdf_document.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/parser/cfdf_document.h" 7 #include "core/fpdfapi/parser/cfdf_document.h"
8 8
9 #include "core/fpdfapi/edit/cpdf_creator.h" 9 #include "core/fpdfapi/edit/cpdf_creator.h"
10 #include "core/fpdfapi/parser/cpdf_dictionary.h" 10 #include "core/fpdfapi/parser/cpdf_dictionary.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 word = parser.GetNextWord(nullptr); 73 word = parser.GetNextWord(nullptr);
74 if (word != "endobj") 74 if (word != "endobj")
75 break; 75 break;
76 } else { 76 } else {
77 if (word != "trailer") 77 if (word != "trailer")
78 break; 78 break;
79 79
80 if (CPDF_Dictionary* pMainDict = 80 if (CPDF_Dictionary* pMainDict =
81 ToDictionary(parser.GetObject(this, 0, 0, true))) { 81 ToDictionary(parser.GetObject(this, 0, 0, true))) {
82 m_pRootDict = pMainDict->GetDictFor("Root"); 82 m_pRootDict = pMainDict->GetDictFor("Root");
83 pMainDict->Release(); 83 delete pMainDict;
84 } 84 }
85 break; 85 break;
86 } 86 }
87 } 87 }
88 } 88 }
89 89
90 FX_BOOL CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const { 90 FX_BOOL CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const {
91 if (!m_pRootDict) 91 if (!m_pRootDict)
92 return FALSE; 92 return FALSE;
93 93
94 buf << "%FDF-1.2\r\n"; 94 buf << "%FDF-1.2\r\n";
95 for (const auto& pair : *this) 95 for (const auto& pair : *this)
96 buf << pair.first << " 0 obj\r\n" 96 buf << pair.first << " 0 obj\r\n"
97 << pair.second.get() << "\r\nendobj\r\n\r\n"; 97 << pair.second.get() << "\r\nendobj\r\n\r\n";
98 98
99 buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum() 99 buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum()
100 << " 0 R>>\r\n%%EOF\r\n"; 100 << " 0 R>>\r\n%%EOF\r\n";
101 return TRUE; 101 return TRUE;
102 } 102 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698