core/fpdfapi/fpdf_font/cpdf_simplefont.h - Issue 2384853002: Detect resursive loading of type3 font char to avoid infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/cpdf_simplefont.h

Issue 2384853002: Detect resursive loading of type3 font char to avoid infinite loop (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/cpdf_simplefont.h

diff --git a/core/fpdfapi/fpdf_font/cpdf_simplefont.h b/core/fpdfapi/fpdf_font/cpdf_simplefont.h

index 47067687a34ac1d56a56c8b1cb85746a73502037..f286c1a22883e105277c18c8550b194cf9fda37a 100644

--- a/core/fpdfapi/fpdf_font/cpdf_simplefont.h

+++ b/core/fpdfapi/fpdf_font/cpdf_simplefont.h

@@ -20,8 +20,8 @@ class CPDF_SimpleFont : public CPDF_Font {

~CPDF_SimpleFont() override;

// CPDF_Font

- int GetCharWidthF(uint32_t charcode, int level = 0) override;

- FX_RECT GetCharBBox(uint32_t charcode, int level = 0) override;

+ int GetCharWidthF(uint32_t charcode) override;

+ FX_RECT GetCharBBox(uint32_t charcode) override;

int GlyphFromCharCode(uint32_t charcode, bool* pVertGlyph) override;

bool IsUnicodeCompatible() const override;

CFX_WideString UnicodeFromCharCode(uint32_t charcode) const override;

« no previous file with comments | « core/fpdfapi/fpdf_font/cpdf_font.h ('k') | core/fpdfapi/fpdf_font/cpdf_simplefont.cpp » ('j') | no next file with comments »