VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.

Committed: https://crrev.com/a2fc9a109f9280ca953e18a5f82c253ded6ddc26
Cr-Commit-Position: refs/heads/master@{#422534}

[mcasas, 2016-09-30 21:05:27]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-30 22:00:05]

Description was changed from

==========
VideoCapture: migrate VideoCapture renderer-->host messages to mojo 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.
==========

to

==========
VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.
==========

[mcasas, 2016-09-30 22:06:04]

mcasas@chromium.org changed reviewers:
+ rockot@chromium.org, tibell@chromium.org

[mcasas, 2016-09-30 22:06:05]

rockot@ / tibell@ PTAL

tsepez@ new file video_capture.mojom plz

[Ken Rockot(use gerrit already), 2016-10-03 17:35:26]

lgtm

[mcasas, 2016-10-03 17:39:17]

mcasas@chromium.org changed reviewers:
+ chfremer@chromium.org, tsepez@chromium.org

[mcasas, 2016-10-03 17:39:18]

tsepez@ PTAL at IPC messages --> mojo part

chfremer@ PTAL/FYI

[Tom Sepez, 2016-10-03 18:12:58]

mojom lgtm

[mcasas, 2016-10-03 19:33:17]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org

[mcasas, 2016-10-03 19:33:17]

avi@ content/ RS plz

[Avi (use Gerrit), 2016-10-03 19:37:22]

lgtm

stampity stamp

[chfremer, 2016-10-03 19:58:42]

lgtm % nits

https://codereview.chromium.org/2384843002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_host.h (right):

https://codereview.chromium.org/2384843002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_host.h:125:
media::VideoCaptureSessionId capture_session_id);
nit: Since we are already touching this code, we could increase consistency by
deciding to name this parameter either "capture_session_id" or "session_id"
consistently across these methods.

[mcasas, 2016-10-03 20:15:42]

https://codereview.chromium.org/2384843002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_host.h (right):

https://codereview.chromium.org/2384843002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_host.h:125:
media::VideoCaptureSessionId capture_session_id);
On 2016/10/03 19:58:42, chfremer wrote:
> nit: Since we are already touching this code, we could increase consistency by
> deciding to name this parameter either "capture_session_id" or "session_id"
> consistently across these methods.

Absolutely! Im doing it in the next CL :)

[mcasas, 2016-10-03 20:15:48]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:16:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:17:18]

Description was changed from

==========
VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.
==========

to

==========
VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.
==========

[commit-bot: I haz the power, 2016-10-03 21:17:19]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-03 21:19:16]

Description was changed from

==========
VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.
==========

to

==========
VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.

Committed: https://crrev.com/a2fc9a109f9280ca953e18a5f82c253ded6ddc26
Cr-Commit-Position: refs/heads/master@{#422534}
==========

[commit-bot: I haz the power, 2016-10-03 21:19:17]

Patchset 1 (id:??) landed as
https://crrev.com/a2fc9a109f9280ca953e18a5f82c253ded6ddc26
Cr-Commit-Position: refs/heads/master@{#422534}

[mcasas, 2016-10-04 00:54:37]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2393483002/ by mcasas@chromium.org.

The reason for reverting is: Ouch! Messages are called Stop, etc
but the mojom calls them StopCapture !
==> the new messages are not being
called :(
Reverting to reland soon..

[mcasas, 2016-10-04 01:00:04]

Patchset #2 (id:40001) has been deleted