Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2384833002: Revert of Notify the renderer if a history navigation has no subframe items. (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
4 years, 2 months ago
Reviewers:
alexmos, nasko
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of Notify the renderer if a history navigation has no subframe items. (patchset #1 id:1 of https://codereview.chromium.org/2380943006/ ) Reason for revert: Broke compile on M54. Original issue's description: > Notify the renderer if a history navigation has no subframe items. > > In this case, the renderer does not need to consult the browser > process if subframes are created during the navigation. Since there > are no history items for it, the renderer can just load the default > URL. > > BUG=638088, 639842 > TEST=Restore chrome://settings after disabling MD settings mode. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2316003002 > Cr-Commit-Position: refs/heads/master@{#420486} > (cherry picked from commit 45b3bba45f5c1276726541db2f6f8ca6c5e05b65) > > Committed: https://chromium.googlesource.com/chromium/src/+/2c38c57dd850f83ba7d1a6713a0552175200efd1 TBR=alexmos@chromium.org,nasko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638088, 639842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -141 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/navigation_params.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/common/navigation_params.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +3 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Charlie Reis
Created Revert of Notify the renderer if a history navigation has no subframe items.
4 years, 2 months ago (2016-09-30 20:44:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384833002/1
4 years, 2 months ago (2016-09-30 20:44:22 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 20:48:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698