Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: chromecast/public/avsettings.h

Issue 2384823002: Add SetVideoMode API to avsettings (Closed)
Patch Set: Addressed comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_PUBLIC_AVSETTINGS_H_ 5 #ifndef CHROMECAST_PUBLIC_AVSETTINGS_H_
6 #define CHROMECAST_PUBLIC_AVSETTINGS_H_ 6 #define CHROMECAST_PUBLIC_AVSETTINGS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "output_restrictions.h" 10 #include "output_restrictions.h"
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 284
285 // Supported HDR output modes. 285 // Supported HDR output modes.
286 enum HdrOutputType { 286 enum HdrOutputType {
287 HDR_OUTPUT_SDR, // not HDR 287 HDR_OUTPUT_SDR, // not HDR
288 HDR_OUTPUT_HDR, // HDR with static metadata 288 HDR_OUTPUT_HDR, // HDR with static metadata
289 HDR_OUTPUT_DOLBYVISION // DolbyVision output 289 HDR_OUTPUT_DOLBYVISION // DolbyVision output
290 }; 290 };
291 291
292 // Gets the current HDR output type. 292 // Gets the current HDR output type.
293 virtual HdrOutputType GetHdrOutputType() = 0; 293 virtual HdrOutputType GetHdrOutputType() = 0;
294
295 // Sets the HDMI video mode according to the given parameters:
296 //
halliwell 2016/10/03 21:05:28 nit, can lose blank line
297 // |allow_4k|: if false, the resolution set will not be a 4K resolution.
298 //
halliwell 2016/10/03 21:05:28 ditto
299 // |optimize_for_fps|: *Attempts* to pick a refresh rate optimal for the
300 // given content frame rate. |optimize_for_fps| is expressed as framerate
301 // * 100. I.e. 24hz -> 2400, 23.98hz -> 2398, etc. Values <= 0 are ignored.
302 //
303 // Returns:
304 // - true if HDMI video mode change is beginning. Caller should wait for
305 // SCREEN_INFO_CHANGED event for mode change to complete.
306 // - false if no HDMI video mode change has begun. This could be because
307 // HDMI is disconnected, or the current resolution is already good for the
308 // given parameters.
309 //
halliwell 2016/10/03 21:05:28 nit, lose one of these blank lines.
310 //
311 // This API only applies to devices that output HDMI, otherwise return false.
halliwell 2016/10/03 21:05:27 This sentence is weird. Just "Non-HDMI devices sh
312 virtual bool SetHdmiVideoMode(bool allow_4k, int optimize_for_fps) = 0;
294 }; 313 };
295 314
296 } // namespace chromecast 315 } // namespace chromecast
297 316
298 #endif // CHROMECAST_PUBLIC_AVSETTINGS_H_ 317 #endif // CHROMECAST_PUBLIC_AVSETTINGS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698