content/browser/renderer_host/render_widget_host_delegate.h - Issue 2384813002: Don't wait to close tabs waiting for JavaScript dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 2384813002: Don't wait to close tabs waiting for JavaScript dialogs. (Closed)

Patch Set: now a bit on webcontents, no timer fiddling Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_delegate.h

diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h

index 2f3a2b37023ed95cd7ad8f894bbefef6d064fd76..24db246cbc7c25b30fce5b785bb212598fa74deb 100644

--- a/content/browser/renderer_host/render_widget_host_delegate.h

+++ b/content/browser/renderer_host/render_widget_host_delegate.h

@@ -151,7 +151,8 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {

RENDERER_UNRESPONSIVE_BEFORE_UNLOAD = 4,

RENDERER_UNRESPONSIVE_UNLOAD = 5,

RENDERER_UNRESPONSIVE_CLOSE_PAGE = 6,

- RENDERER_UNRESPONSIVE_MAX = RENDERER_UNRESPONSIVE_CLOSE_PAGE,

+ RENDERER_UNRESPONSIVE_DIALOG_SHOWING = 7,

+ RENDERER_UNRESPONSIVE_MAX = RENDERER_UNRESPONSIVE_DIALOG_SHOWING,

};

// Notification that the renderer has become unresponsive. The