Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 2384813002: Don't wait to close tabs waiting for JavaScript dialogs. (Closed)
Patch Set: now a bit on webcontents, no timer fiddling Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_delegate.h
diff --git a/content/browser/frame_host/render_frame_host_delegate.h b/content/browser/frame_host/render_frame_host_delegate.h
index d354978f79cb8387f9f76d57109048359b0ab229..28666dce8d6c76efdc122efd939ae2d51573d669 100644
--- a/content/browser/frame_host/render_frame_host_delegate.h
+++ b/content/browser/frame_host/render_frame_host_delegate.h
@@ -56,7 +56,7 @@ class CONTENT_EXPORT RenderFrameHostDelegate {
virtual bool OnMessageReceived(RenderFrameHost* render_frame_host,
const IPC::Message& message);
- // Allows the delegate to filter incoming associated inteface requests.
+ // Allows the delegate to filter incoming associated interface requests.
virtual void OnAssociatedInterfaceRequest(
RenderFrameHost* render_frame_host,
const std::string& interface_name,
@@ -95,6 +95,8 @@ class CONTENT_EXPORT RenderFrameHostDelegate {
bool is_reload,
IPC::Message* reply_msg) {}
+ virtual bool IsJavaScriptDialogShowing() const;
+
// Called when a file selection is to be done.
virtual void RunFileChooser(RenderFrameHost* render_frame_host,
const FileChooserParams& params) {}

Powered by Google App Engine
This is Rietveld 408576698