|
|
Chromium Code Reviews
Description[SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView
This fixes paint invalidation rect of LayoutView that was incorrectly
applied frame content clip and scroll. This fixes some wrong rects
in paint/invalidation/repaint-during-scroll-with-zoom.html in
slimmingPaintInvalidation mode. (The test still fails because of
frame view preTranslation rounding.)
This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace()
in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to
LayoutView::mapToVisualRectInAncestorSpace().
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp?rcl=0&l=425)
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/c3eed56461d77c33ffb06ffe20e400bf6920448f
Cr-Commit-Position: refs/heads/master@{#422254}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== [SPInvalidation ] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) BUG=646176 ========== to ========== [SPInvalidation ] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [SPInvalidation ] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== [SPInvalidation ] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== [SPInvalidation ] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== [SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chrishtr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== [SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== [SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/c3eed56461d77c33ffb06ffe20e400bf6920448f Cr-Commit-Position: refs/heads/master@{#422254} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c3eed56461d77c33ffb06ffe20e400bf6920448f Cr-Commit-Position: refs/heads/master@{#422254} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
