Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2384803003: [SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Don't apply FrameView content clip and scroll on LayoutView This fixes paint invalidation rect of LayoutView that was incorrectly applied frame content clip and scroll. This fixes some wrong rects in paint/invalidation/repaint-during-scroll-with-zoom.html in slimmingPaintInvalidation mode. (The test still fails because of frame view preTranslation rounding.) This change corresponds SPv1 code in slowMapToVisualRectInAncestorSpace() in PaintInvalidationState.cpp passing InputIsInFrameCoordinates to LayoutView::mapToVisualRectInAncestorSpace(). (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp?rcl=0&l=425) BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/c3eed56461d77c33ffb06ffe20e400bf6920448f Cr-Commit-Position: refs/heads/master@{#422254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 3 chunks +38 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Xianzhu
4 years, 2 months ago (2016-09-30 19:40:14 UTC) #7
chrishtr
lgtm
4 years, 2 months ago (2016-09-30 22:52:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384803003/1
4 years, 2 months ago (2016-09-30 22:53:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 22:59:13 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 23:02:49 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3eed56461d77c33ffb06ffe20e400bf6920448f
Cr-Commit-Position: refs/heads/master@{#422254}

Powered by Google App Engine
This is Rietveld 408576698