Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2384803002: [Remoting Android] Export CreditsActivity (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
Lambros, joedow
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Export CreditsActivity Currently CreditsActivity is not marked as exported, which means the internal Help&Feedback library doesn't have permission to launch CreditsActivity and therefore we can't move the Credits menu item back to Help&Feedback's overflow menu. This CL marks CreditsActivity as exported to solve the problem above. BUG=613604 Committed: https://crrev.com/3ce42140740209a646cffb2178455533906dc811 Cr-Commit-Position: refs/heads/master@{#422519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/android/java/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Yuwei
PTAL. Thanks!
4 years, 2 months ago (2016-09-30 18:37:45 UTC) #2
Lambros
lgtm
4 years, 2 months ago (2016-10-03 20:34:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384803002/1
4 years, 2 months ago (2016-10-03 20:35:43 UTC) #5
Yuwei
On 2016/10/03 20:34:47, Lambros wrote: > lgtm Thanks!
4 years, 2 months ago (2016-10-03 20:36:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 20:46:42 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:51:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ce42140740209a646cffb2178455533906dc811
Cr-Commit-Position: refs/heads/master@{#422519}

Powered by Google App Engine
This is Rietveld 408576698