Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 23848006: Put console.time into a separate trace event category. (Closed)

Created:
7 years, 3 months ago by ernstm
Modified:
7 years, 3 months ago
Reviewers:
jamesr, nduca, tonyg
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Put console.time into a separate trace event category. In rendering benchmarks we want to only capture trace events that are required for the benchmark. console.time is used frequently, but everything else from the 'webkit' category is not. Putting console.time into a separate category 'webkit.console' will reduce overhead and make trace buffer overflows less likely. R=jamesr@chromium.org, nduca@chromium.org, tonyg@chromium.org BUG=264308 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/page/ConsoleBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ernstm
7 years, 3 months ago (2013-09-05 20:39:31 UTC) #1
tonyg
lgtm
7 years, 3 months ago (2013-09-05 21:05:00 UTC) #2
nduca
awesome lgtm
7 years, 3 months ago (2013-09-05 21:41:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/23848006/1
7 years, 3 months ago (2013-09-06 16:29:54 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 17:43:37 UTC) #5
Message was sent while issue was closed.
Change committed as 157377

Powered by Google App Engine
This is Rietveld 408576698