|
|
Created:
4 years, 2 months ago by Elly Fong-Jones Modified:
4 years, 2 months ago Reviewers:
dmazzoni CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncontent_browsertests: reenable DumpAccessibilityEventsTest.* on Windows
BUG=617146
Committed: https://crrev.com/de6ba99f4907ca27a6efbd1835d824baa3e28ad8
Cr-Commit-Position: refs/heads/master@{#422807}
Patch Set 1 #Patch Set 2 : disable failing tests on win #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run
Description was changed from ========== content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 ========== to ========== content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 ==========
ellyjones@chromium.org changed reviewers: + dmazzoni@chromium.org
dmazzoni: ptal? :)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
On 2016/09/30 18:41:15, dmazzoni wrote: > lgtm dmazzoni@: I don't have a Windows machine - can I hand fixing these tests over to you, if I mark the ones that are failing as individually disabled?
still lgtm Yes, that's fine - please enable the ones that passed, and disable the ones that didn't using the DISABLED_ macro. I'll work on fixing the ones that failed. Thanks!
The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ellyjones@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2384793002/#ps20001 (title: "disable failing tests on win")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 ========== to ========== content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 ========== to ========== content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 Committed: https://crrev.com/de6ba99f4907ca27a6efbd1835d824baa3e28ad8 Cr-Commit-Position: refs/heads/master@{#422807} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/de6ba99f4907ca27a6efbd1835d824baa3e28ad8 Cr-Commit-Position: refs/heads/master@{#422807} |