Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2384793002: content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content_browsertests: reenable DumpAccessibilityEventsTest.* on Windows BUG=617146 Committed: https://crrev.com/de6ba99f4907ca27a6efbd1835d824baa3e28ad8 Cr-Commit-Position: refs/heads/master@{#422807}

Patch Set 1 #

Patch Set 2 : disable failing tests on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 4 chunks +27 lines, -31 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Elly Fong-Jones
dmazzoni: ptal? :)
4 years, 2 months ago (2016-09-30 18:14:35 UTC) #4
dmazzoni
lgtm
4 years, 2 months ago (2016-09-30 18:41:15 UTC) #6
Elly Fong-Jones
On 2016/09/30 18:41:15, dmazzoni wrote: > lgtm dmazzoni@: I don't have a Windows machine - ...
4 years, 2 months ago (2016-10-03 17:14:27 UTC) #9
dmazzoni
still lgtm Yes, that's fine - please enable the ones that passed, and disable the ...
4 years, 2 months ago (2016-10-03 18:16:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384793002/20001
4 years, 2 months ago (2016-10-04 15:30:50 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 15:36:10 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 15:38:09 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de6ba99f4907ca27a6efbd1835d824baa3e28ad8
Cr-Commit-Position: refs/heads/master@{#422807}

Powered by Google App Engine
This is Rietveld 408576698