Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384783003: DevTools: split Sources tree into Network and Filesystem trees. (Closed)

Created:
4 years, 2 months ago by pfeldman
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: split Sources tree into Network and Filesystem trees. BUG=649837 Committed: https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca Cr-Commit-Position: refs/heads/master@{#422640}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments addressed #

Messages

Total messages: 10 (4 generated)
pfeldman
4 years, 2 months ago (2016-09-30 22:17:09 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/module.json File third_party/WebKit/Source/devtools/front_end/sources/module.json (right): https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/module.json#newcode265 third_party/WebKit/Source/devtools/front_end/sources/module.json:265: "viewId": "navigator-source", navigator-sources https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/module.json#newcode266 third_party/WebKit/Source/devtools/front_end/sources/module.json:266: "className": "WebInspector.SourceNavigatorView", Sources ...
4 years, 2 months ago (2016-10-01 01:09:21 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (left): https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#oldcode70 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:70: tabbedPane.setShrinkableTabs(true); nicee https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js File third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js (right): https://codereview.chromium.org/2384783003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js#newcode419 third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js:419: ...
4 years, 2 months ago (2016-10-01 03:05:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384783003/20001
4 years, 2 months ago (2016-10-03 22:20:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 00:49:14 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:52:46 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca
Cr-Commit-Position: refs/heads/master@{#422640}

Powered by Google App Engine
This is Rietveld 408576698