Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2384763002: SkRWBuffer: preallocate 'initialCapacity' (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRWBuffer: preallocate 'initialCapacity' We're currently ignoring the hint, resulting in multiple unneeded allocations later. BUG=chromium:651698 R=scroggo@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2384763002 Committed: https://skia.googlesource.com/skia/+/2e36e88f40c8a37043d5b9ef17bc72b69a394b95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/core/SkRWBuffer.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
f(malita)
4 years, 2 months ago (2016-09-30 16:36:44 UTC) #4
scroggo
lgtm
4 years, 2 months ago (2016-09-30 17:34:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384763002/1
4 years, 2 months ago (2016-09-30 17:50:53 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:52:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2e36e88f40c8a37043d5b9ef17bc72b69a394b95

Powered by Google App Engine
This is Rietveld 408576698