Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 238473002: Mark tests as failing for upcoming change. (Closed)

Created:
6 years, 8 months ago by DaleCurtis
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Mark tests as failing for upcoming change. https://codereview.chromium.org/220103002/ will cause these tests to fail. They'll need to be updated after that patch has rolled into blink. BUG=356805 TEST=LayoutTests. NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
DaleCurtis
6 years, 8 months ago (2014-04-15 00:55:19 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-15 00:57:43 UTC) #2
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-15 00:59:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/238473002/1
6 years, 8 months ago (2014-04-15 01:00:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 01:00:50 UTC) #5
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 8 months ago (2014-04-15 01:00:51 UTC) #6
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-15 01:01:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/238473002/1
6 years, 8 months ago (2014-04-15 01:02:23 UTC) #8
DaleCurtis
The CQ bit was unchecked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-15 01:06:48 UTC) #9
DaleCurtis
lol? Apparently "I can't make sense out of the commit message" is code for "I ...
6 years, 8 months ago (2014-04-15 01:07:28 UTC) #10
DaleCurtis
cc:phajdan.jr who seems to be working on the CQ these days.
6 years, 8 months ago (2014-04-15 01:09:02 UTC) #11
DaleCurtis
cc:phajdan.jr who seems to be working on the CQ these days.
6 years, 8 months ago (2014-04-15 01:09:03 UTC) #12
Paweł Hajdan Jr.
6 years, 8 months ago (2014-04-17 14:22:38 UTC) #13
Message was sent while issue was closed.
On 2014/04/15 01:09:03, DaleCurtis wrote:
> cc:phajdan.jr who seems to be working on the CQ these days.

Please report CQ issues to chrome-troopers@google.com as mentioned in a
chromium-dev PSA. There are some known issues.

Powered by Google App Engine
This is Rietveld 408576698