Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2384723002:
Worker: Shorten running time of DedicatedWorkerTests (Closed)
|
Created:
4 years, 2 months ago by nhiroki Modified:
4 years, 2 months ago Reviewers:
falken CC:
chromium-reviews, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Shorten running time of DedicatedWorkerTests
DedicatedWorkerTests are very slow compared to other tests. According to the
report (https://crbug.com/650346), these take 20% of the running time of
webkit_unit_tests. This CL saves the running time by shortening delays for
postDelayedTask(), setInterval() etc used in the tests.
Before this CL (Linux Debug Build):
[1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms)
[2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms)
[3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms)
[4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms)
[5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms)
[6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms)
[7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms)
[8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms)
[9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms)
[10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms)
After this CL (Linux Debug Build):
[1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms)
[2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms)
[3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms)
[4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms)
[5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms)
[6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms)
[7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms)
[8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms)
[9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms)
[10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms)
BUG=650346
Committed: https://crrev.com/4fc0c9e997c07fafa8089520db5286b4f0f22817
Cr-Commit-Position: refs/heads/master@{#423789}
Patch Set 1 #
Total comments: 4
Patch Set 2 : rebase #Patch Set 3 : shorten the delays more #
Total comments: 8
Patch Set 4 : revise comments #
Messages
Total messages: 23 (13 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nhiroki@chromium.org changed reviewers: + falken@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I normally am opposed to setTimeout/Interval in tests but I guess it's needed for this test that's specifically testing timers in DedicatedWorker? How were the timeouts chosen; can they be even smaller? https://codereview.chromium.org/2384723002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp (right): https://codereview.chromium.org/2384723002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:45: workerObjectProxy().m_maxIntervalInSec = 0.02; How were these chosen? Can it be even smaller? https://codereview.chromium.org/2384723002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:216: const String sourceCode = "setTimeout(function() {}, 5);"; Does the test fail if these are made setTimeout(0)?
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/03 01:10:47, falken wrote: > I normally am opposed to setTimeout/Interval in tests but I guess it's needed > for this test that's specifically testing timers in DedicatedWorker? Yes, setTimeout/Interval are necessary for testing. These test that the timers correctly count setTimeout/Interval as pending activities > How were the timeouts chosen; can they be even smaller? They are chosen by trial-and-error. I'll make an inline comment about a room of shortening the delays more.
Thank you! Updated. https://codereview.chromium.org/2384723002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp (right): https://codereview.chromium.org/2384723002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:45: workerObjectProxy().m_maxIntervalInSec = 0.02; On 2016/10/03 01:10:46, falken wrote: > How were these chosen? Can it be even smaller? Making these intervals smaller causes test flakiness. The main thread needs to wait until message confirmation and activity report separately. If the intervals are very short, they are notified to the main thread almost at the same time and the thread may miss the second notification. We could make them more deterministic, but it requires more amount of work. If possible, I'd like to defer doing it. https://codereview.chromium.org/2384723002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:216: const String sourceCode = "setTimeout(function() {}, 5);"; On 2016/10/03 01:10:47, falken wrote: > Does the test fail if these are made setTimeout(0)? It's feasible. Done.
Description was changed from ========== Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report (https://crbug.com/650346), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL: [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (204 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (198 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (198 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1207 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1403 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (166 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (160 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (166 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1175 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1372 ms) After this CL: [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (107 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (106 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (100 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (116 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (134 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (67 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (73 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (71 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (86 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (95 ms) BUG=650346 ========== to ========== Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report (https://crbug.com/650346), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms) After this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms) BUG=650346 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for the explanations. Some more nitty comments. https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp (right): https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:25: const double kMaxIntervalInSec = 0.02; Can you add a comment here like what you said in the code review: "These are chosen by trial-and-error. Making these intervals smaller causes test flakiness. The main thread needs to wait until message confirmation and activity report separately. If the intervals are very short, they are notified to the main thread almost at the same time and the thread may miss the second notification." https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:242: // setInterval() is non-zero because it may hinder worker activities. It's hard to understand this sentence. Can it be more direct "The timer needs a non-zero delay or else worker activities would not run."? https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:303: // setInterval() is non-zero because it may hinder worker activities. ditto https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:338: testing::runDelayedTasks(kMaxIntervalInSec * 1000); The comment doesn't explain the 1000 though. Would it be more clear to do this? const kNumIntervalsToRun = 1000; kMaxIntervalInSec * kNumIntervalsToRun;
Thank you. Updated. https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp (right): https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:25: const double kMaxIntervalInSec = 0.02; On 2016/10/05 01:46:01, falken wrote: > Can you add a comment here like what you said in the code review: > "These are chosen by trial-and-error. Making these intervals smaller causes test > flakiness. The main thread needs to > wait until message confirmation and activity report separately. If the intervals > are very short, they are notified to the main thread almost at the same time and > the thread may miss the second notification." Done. https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:242: // setInterval() is non-zero because it may hinder worker activities. On 2016/10/05 01:46:01, falken wrote: > It's hard to understand this sentence. Can it be more direct "The timer needs a > non-zero delay or else worker activities would not run."? Done. https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:303: // setInterval() is non-zero because it may hinder worker activities. On 2016/10/05 01:46:01, falken wrote: > ditto Done. https://codereview.chromium.org/2384723002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:338: testing::runDelayedTasks(kMaxIntervalInSec * 1000); On 2016/10/05 01:46:01, falken wrote: > The comment doesn't explain the 1000 though. Would it be more clear to do this? > const kNumIntervalsToRun = 1000; > kMaxIntervalInSec * kNumIntervalsToRun; Done. Note that "1000" is used for converting a unit from seconds to milliseconds.
lgtm
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report (https://crbug.com/650346), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms) After this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms) BUG=650346 ========== to ========== Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report (https://crbug.com/650346), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms) After this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms) BUG=650346 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report (https://crbug.com/650346), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms) After this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms) BUG=650346 ========== to ========== Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report (https://crbug.com/650346), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms) After this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms) BUG=650346 Committed: https://crrev.com/4fc0c9e997c07fafa8089520db5286b4f0f22817 Cr-Commit-Position: refs/heads/master@{#423789} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/4fc0c9e997c07fafa8089520db5286b4f0f22817 Cr-Commit-Position: refs/heads/master@{#423789} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
