Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2384713005: Revert of Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
pdr., fs
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement (patchset #1 id:1 of https://codereview.chromium.org/2387513002/ ) Reason for revert: This is just a test, I won't land the revert. Original issue's description: > Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement > > This folds non-property-construction methods from > SVGAnimatedTypeAnimator into SVGAnimateElement and gets rid of simple > forwarding methods. This leaves SVGAnimatedTypeAnimator as a property- > value factory. > > BUG=641437 > > Committed: https://crrev.com/40d243776ba93a704b64c372303594a4189984ac > Cr-Commit-Position: refs/heads/master@{#422188} TBR=pdr@chromium.org,fs@opera.com BUG=641437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -89 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 6 chunks +9 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h View 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 7 chunks +97 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (12 generated)
Nico
4 years, 2 months ago (2016-10-01 02:19:55 UTC) #1
Created Revert of Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement

Powered by Google App Engine
This is Rietveld 408576698