[downloads] Correctly plumb client ID for download file scanning.

[downloads] Correctly plumb client ID for download file scanning.

The client GUID for download file scanning wasn't plumbed all the way
through the download system. This caused the underlying quarantine logic
to always apply the mark-of-the-web even if the local configuration
wouldn't have required it.

The plumbing for the client GUID was broken in 4350f6a0 (Mar 14, 2016).
IAttachmentExecute::Save() continued to function since the client GUID
is optional. However, bd57338f (Sep 21, 2016) made it so that Chrome
sets the mark-of-the-web directly if no client GUID is present. This CL
fixes the plumbing of the client GUID so that AttachmentServices is
correctly invoked.

Unit testing ensured that downloads were always receiving the MOTW when
appropriate. However, there were no end-to-end test that was ensuring
that the MOTW didn't get applied when it is not necessary.

BUG=650111
Committed: https://crrev.com/db9e50adb265249e4082721b10d15050901be42b
Cr-Commit-Position: refs/heads/master@{#422422}

[asanka, 2016-10-01 00:04:28]

The CQ bit was checked by asanka@chromium.org to run a CQ dry run

[asanka, 2016-10-01 00:04:59]

asanka@chromium.org changed reviewers:
+ svaldez@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:05:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asanka, 2016-10-02 19:22:27]

The CQ bit was checked by asanka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 19:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 20:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 20:08:07]

Dry run: This issue passed the CQ dry run.

[asanka, 2016-10-02 21:57:36]

Description was changed from

==========
[downloads] Correctly plumb client ID for download file scanning.

Due to a recent regression, the client GUID for download file scanning
wasn't plumbed all the way through the download system. This caused the
underlying quarantine logic to always apply the mark-of-the-web even if
the local configuration wouldn't have required it.

BUG=650111
==========

to

==========
[downloads] Correctly plumb client ID for download file scanning.

The client GUID for download file scanning wasn't plumbed all the way
through the download system. This caused the underlying quarantine logic
to always apply the mark-of-the-web even if the local configuration
wouldn't have required it.

The plumbing for the client GUID was broken in
4350f6a0843ceb70885f375f9dcf0df9c081faf0 (Mar 14, 2016), but
IAttachmentExecute::Save() continued to function since the client GUID
is optional. However, bd57338ff5d58fff3147982c3f631cbe43e86f9c (Sep 21,
2016) made it so that if no client GUID is present, Chrome sets the
mark-of-the-web directly.

BUG=650111
==========

[asanka, 2016-10-03 13:34:37]

Description was changed from

==========
[downloads] Correctly plumb client ID for download file scanning.

The client GUID for download file scanning wasn't plumbed all the way
through the download system. This caused the underlying quarantine logic
to always apply the mark-of-the-web even if the local configuration
wouldn't have required it.

The plumbing for the client GUID was broken in
4350f6a0843ceb70885f375f9dcf0df9c081faf0 (Mar 14, 2016), but
IAttachmentExecute::Save() continued to function since the client GUID
is optional. However, bd57338ff5d58fff3147982c3f631cbe43e86f9c (Sep 21,
2016) made it so that if no client GUID is present, Chrome sets the
mark-of-the-web directly.

BUG=650111
==========

to

==========
[downloads] Correctly plumb client ID for download file scanning.

The client GUID for download file scanning wasn't plumbed all the way
through the download system. This caused the underlying quarantine logic
to always apply the mark-of-the-web even if the local configuration
wouldn't have required it.

The plumbing for the client GUID was broken in 4350f6a0 (Mar 14, 2016).
IAttachmentExecute::Save() continued to function since the client GUID
is optional. However, bd57338f (Sep 21, 2016) made it so that Chrome
sets the mark-of-the-web directly if no client GUID is present. This CL
fixes the plumbing of the client GUID so that AttachmentServices is
correctly invoked.

Unit testing ensured that downloads were always receiving the MOTW when
appropriate. However, there were no end-to-end test that was ensuring
that the MOTW didn't get applied when it is not necessary.

BUG=650111
==========

[svaldez, 2016-10-03 14:37:18]

lgtm

[asanka, 2016-10-03 14:55:33]

Thanks!

[asanka, 2016-10-03 14:55:36]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2016-10-03 14:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 15:00:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 15:02:55]

Description was changed from

==========
[downloads] Correctly plumb client ID for download file scanning.

The client GUID for download file scanning wasn't plumbed all the way
through the download system. This caused the underlying quarantine logic
to always apply the mark-of-the-web even if the local configuration
wouldn't have required it.

The plumbing for the client GUID was broken in 4350f6a0 (Mar 14, 2016).
IAttachmentExecute::Save() continued to function since the client GUID
is optional. However, bd57338f (Sep 21, 2016) made it so that Chrome
sets the mark-of-the-web directly if no client GUID is present. This CL
fixes the plumbing of the client GUID so that AttachmentServices is
correctly invoked.

Unit testing ensured that downloads were always receiving the MOTW when
appropriate. However, there were no end-to-end test that was ensuring
that the MOTW didn't get applied when it is not necessary.

BUG=650111
==========

to

==========
[downloads] Correctly plumb client ID for download file scanning.

The client GUID for download file scanning wasn't plumbed all the way
through the download system. This caused the underlying quarantine logic
to always apply the mark-of-the-web even if the local configuration
wouldn't have required it.

The plumbing for the client GUID was broken in 4350f6a0 (Mar 14, 2016).
IAttachmentExecute::Save() continued to function since the client GUID
is optional. However, bd57338f (Sep 21, 2016) made it so that Chrome
sets the mark-of-the-web directly if no client GUID is present. This CL
fixes the plumbing of the client GUID so that AttachmentServices is
correctly invoked.

Unit testing ensured that downloads were always receiving the MOTW when
appropriate. However, there were no end-to-end test that was ensuring
that the MOTW didn't get applied when it is not necessary.

BUG=650111

Committed: https://crrev.com/db9e50adb265249e4082721b10d15050901be42b
Cr-Commit-Position: refs/heads/master@{#422422}
==========

[commit-bot: I haz the power, 2016-10-03 15:02:56]

Patchset 2 (id:??) landed as
https://crrev.com/db9e50adb265249e4082721b10d15050901be42b
Cr-Commit-Position: refs/heads/master@{#422422}