"Redirecting URLs to Packaged Apps" implementation: revised

chrome/common/extensions/extension_manifest_constants.h

Index: chrome/common/extensions/extension_manifest_constants.h
diff --git a/chrome/common/extensions/extension_manifest_constants.h b/chrome/common/extensions/extension_manifest_constants.h
index bf38691453c35c02a402b77c1815fcd27a0f78b0..c333c7f2a88e23a2f9dd849858943e6c3422f690 100644
--- a/chrome/common/extensions/extension_manifest_constants.h
+++ b/chrome/common/extensions/extension_manifest_constants.h
@@ -232,6 +232,10 @@ namespace extension_manifest_errors {
   extern const char kInvalidTtsVoicesVoiceName[];
   extern const char kInvalidUpdateURL[];
   extern const char kInvalidURLPatternError[];
+  extern const char kInvalidUrlHandlers[];

[benwells, 2013/09/03 01:10:56]

previous nit continued: Note kInvalidURLPatternError and kLaunchURLRequried
versus kInvalidUrlHandler...

URL not Url.

[sergeygs, 2013/09/03 06:15:24]

Agreed, here it probably makes sense, since all these originate from here, and
there are too many URLs around. A later URL->Url renaming will get everything in
one swoop.

+  extern const char kInvalidUrlHandlerPatternElement[];
+  extern const char kInvalidUrlHandlerTitle[];
+  extern const char kInvalidUrlHandlerPattern[];
   extern const char kInvalidVersion[];
   extern const char kInvalidWebAccessibleResourcesList[];
   extern const char kInvalidWebAccessibleResource[];