"Redirecting URLs to Packaged Apps" implementation: revised

chrome/common/extensions/api/url_handlers/url_handlers_parser.h

Index: chrome/common/extensions/api/url_handlers/url_handlers_parser.h
diff --git a/chrome/common/extensions/api/url_handlers/url_handlers_parser.h b/chrome/common/extensions/api/url_handlers/url_handlers_parser.h
new file mode 100644
index 0000000000000000000000000000000000000000..022aae39b73ee6b4d4c1fcf6f1690f7cadebc9bf
--- /dev/null
+++ b/chrome/common/extensions/api/url_handlers/url_handlers_parser.h
@@ -0,0 +1,71 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[benwells, 2013/09/04 23:54:20]

Tiny nit: no (c).

The style changed from 2012 to 2013 for some reason.

[sergeygs, 2013/09/05 09:19:03]

Shouldn't we do one mass replacement and be done with it then? Otherwise it's
inconsistent: all neighboring files have (c). But anyway: done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_API_URL_HANDLERS_URL_HANDLERS_PARSER_H_
+#define CHROME_COMMON_EXTENSIONS_API_URL_HANDLERS_URL_HANDLERS_PARSER_H_
+
+#include <string>
+#include <vector>
+
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest_handler.h"
+#include "extensions/common/url_pattern.h"
+
+class GURL;
+
+namespace extensions {
+
+struct UrlHandlerInfo {

[benwells, 2013/09/04 23:54:20]

Nit: These should be URLHandlerInfo...

[sergeygs, 2013/09/05 09:19:03]

This is a recurring theme. I've talked to the people around, and the current
recommendation is Url. Again, a mass replacement would be nice. Until then,
there will unavoidably be classes that will appear in both old (URL) and new
(Url) worlds.

+  UrlHandlerInfo();
+  ~UrlHandlerInfo();
+
+  // ID identifying this handler in the manifest.
+  std::string id;
+  // Handler title to display in all relevant UI.
+  std::string title;
+  // URL patterns associated with this handler.
+  URLPatternSet patterns;
+};
+
+struct UrlHandlers : public Extension::ManifestData {
+  UrlHandlers();
+  virtual ~UrlHandlers();
+
+  // Returns an array of URL handlers |extension| has defined in its manifest.
+  static const std::vector<UrlHandlerInfo>* GetUrlHandlers(
+      const Extension* extension);
+
+  // Determines whether |extension| has at least one URL handler that matches
+  // |url|.
+  static bool CanExtensionHandleUrl(
+      const Extension* extension,
+      const GURL& url);
+
+  // Finds a matching URL handler for |extension|, if any. Returns NULL in none
+  // are found.
+  static const UrlHandlerInfo* FindMatchingUrlHandler(
+      const Extension* extension,
+      const GURL& url);
+
+  std::vector<UrlHandlerInfo> handlers;
+};
+
+// Parses the "url_handlers" manifest key.
+class UrlHandlersParser : public ManifestHandler {
+ public:
+  UrlHandlersParser();
+  virtual ~UrlHandlersParser();
+
+  // ManifestHandler API
+  virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
+
+ private:
+  virtual const std::vector<std::string> Keys() const OVERRIDE;
+
+  DISALLOW_COPY_AND_ASSIGN(UrlHandlersParser);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_COMMON_EXTENSIONS_API_URL_HANDLERS_URL_HANDLERS_PARSER_H_