"Redirecting URLs to Packaged Apps" implementation: revised

chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/logging.h"
@@ skipping 54 matching lines @@
 #include "chrome/browser/android/intercept_download_resource_throttle.h"
 #include "components/navigation_interception/intercept_navigation_delegate.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/merge_session_throttle.h"
 // TODO(oshima): Enable this for other platforms.
 #include "chrome/browser/renderer_host/offline_resource_throttle.h"
 #endif
 
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#include "chrome/browser/apps/app_url_redirector.h"
+#endif
+
 using content::BrowserThread;
 using content::RenderViewHost;
 using content::ResourceDispatcherHostLoginDelegate;
 using content::ResourceRequestInfo;
 using extensions::Extension;
 using extensions::StreamsPrivateAPI;
 
 #if defined(OS_ANDROID)
 using navigation_interception::InterceptNavigationDelegate;
 #endif
@@ skipping 170 matching lines @@
 
   ChromeURLRequestUserData* user_data =
       ChromeURLRequestUserData::Create(request);
   bool is_prerendering = prerender_tracker_->IsPrerenderingOnIOThread(
       child_id, route_id);
   if (is_prerendering) {
     user_data->set_is_prerender(true);
     request->SetPriority(net::IDLE);
   }
 
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+  // Redirect some navigations to apps that have registered matching URL
+  // handlers ('url_handlers' in the manifest).
+  if (!is_prerendering && resource_type == ResourceType::MAIN_FRAME &&

[darin (slow to review), 2013/09/05 23:54:25]

I don't think this file should be built in the OS_IOS build. Have you found
otherwise?

Wouldn't it be better to share the first two checks with OS_ANDROID?

  if (!is_prerendering && resource_type == ResourceType::MAIN_FRAME) {
#if defined(OS_ANDROID)
    ...
#else
    if (request->method() == "GET")
      throttles->push_back(AppUrlRedirector::CreateThrottleFor(request));
#endif
  }

^^^ Seems better to test for GET instead of POST. Since you are only filtering
on navigations it doesn't strictly matter, but in case some other kind of HTTP
method ends up being used for navigations, it might be nice to not accidentally
route those as well to the app.

[sergeygs, 2013/09/06 02:51:14]

Done. I guess you're right about this file not build for OS_IOS.

+      request->method() != "POST") {
+    throttles->push_back(AppUrlRedirector::CreateThrottleFor(request));

[not at google - send to devlin, 2013/09/06 00:51:30]

come to think of it, you should only need to register this if there is an app
that has a URL handler, which in the common case isn't true.

make sure to test adding/removing apps with URL handler(s) though.

[sergeygs, 2013/09/06 02:51:14]

Sure, I'll test that case. This is registered for top-level navigations only, so
it shouldn't be very expensive overall. It could be possible to prefind a
handling app before creating a throttle, but as discussed in person, this seems
to be difficult right now. Leaving as is.

What I can do here easily (just noticed), is skip adding a throttle in
incognito: I'll do that.

[not at google - send to devlin, 2013/09/06 03:02:11]

As more recently discussed in person, the ExtensionInfoMap is already available
to this class so this can actually be simplified some more.

+  }
+#endif
+
 #if defined(OS_ANDROID)
   if (!is_prerendering && resource_type == ResourceType::MAIN_FRAME) {
     throttles->push_back(
         InterceptNavigationDelegate::CreateThrottleFor(request));
   }
 #endif
+
 #if defined(OS_CHROMEOS)
   if (resource_type == ResourceType::MAIN_FRAME) {
     // We check offline first, then check safe browsing so that we still can
     // block unsafe site after we remove offline page.
     throttles->push_back(new OfflineResourceThrottle(
         child_id, route_id, request, appcache_service));
     // Add interstitial page while merge session process (cookie
     // reconstruction from OAuth2 refresh token in ChromeOS login) is still in
     // progress while we are attempting to load a google property.
     throttles->push_back(new MergeSessionThrottle(
@@ skipping 356 matching lines @@
   if (!prerender::PrerenderManager::DoesURLHaveValidScheme(redirect_url) &&
       ResourceRequestInfo::ForRequest(request)->GetAssociatedRenderView(
           &child_id, &route_id) &&
       prerender_tracker_->IsPrerenderingOnIOThread(child_id, route_id)) {
     ReportUnsupportedPrerenderScheme(redirect_url);
     prerender_tracker_->TryCancel(
         child_id, route_id, prerender::FINAL_STATUS_UNSUPPORTED_SCHEME);
     request->Cancel();
   }
 }