"Redirecting URLs to Packaged Apps" implementation: revised

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/child_process_logging.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/content_settings_pattern.h"
+#include "chrome/common/extensions/api/url_handlers/url_handlers_parser.h"
 #include "chrome/common/extensions/chrome_extensions_client.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/extensions/extension_process_policy.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/common/external_ipc_fuzzer.h"
 #include "chrome/common/localized_error.h"
 #include "chrome/common/pepper_permission_util.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/benchmarking_extension.h"
 #include "chrome/renderer/chrome_render_process_observer.h"
 #include "chrome/renderer/chrome_render_view_observer.h"
@@ skipping 31 matching lines @@
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 #include "components/autofill/content/renderer/password_generation_manager.h"
 #include "components/visitedlink/renderer/visitedlink_slave.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/render_view_visitor.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_urls.h"
+#include "extensions/common/switches.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/renderer_resources.h"
 #include "ipc/ipc_sync_channel.h"
 #include "net/base/net_errors.h"
 #include "ppapi/c/private/ppb_nacl_private.h"
 #include "ppapi/c/private/ppb_pdf.h"
 #include "ppapi/shared_impl/ppapi_switches.h"
 #include "third_party/WebKit/public/web/WebCache.h"
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebPluginContainer.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/platform/WebURLError.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
+#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/layout.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/webui/jstemplate_builder.h"
 #include "widevine_cdm_version.h"  // In SHARED_INTERMEDIATE_DIR.
 
 #if defined(ENABLE_WEBRTC)
 #include "chrome/renderer/media/webrtc_logging_message_filter.h"
 #endif
 
@@ skipping 812 matching lines @@
 bool ChromeContentRendererClient::AllowPopup() {
   extensions::ChromeV8Context* current_context =
       extension_dispatcher_->v8_context_set().GetCurrent();
   return current_context && current_context->extension() &&
       (current_context->context_type() ==
        extensions::Feature::BLESSED_EXTENSION_CONTEXT ||
        current_context->context_type() ==
        extensions::Feature::CONTENT_SCRIPT_CONTEXT);
 }
 
+// For top-level navigations, tries to find a platform app that has registered
+// a URL handler matching the URL. If found, delegates further URL processing
+// to the browser (the browser is supposed to launch the app), and returns true
+// to cancel navigation on the renderer side. Otherwise, returns false.
+bool ChromeContentRendererClient::HandleNavigation(
+    WebKit::WebFrame* frame,
+    const WebKit::WebURLRequest& request,
+    WebKit::WebNavigationType type,
+    WebKit::WebNavigationPolicy default_policy,
+    bool is_redirect) {
+  // TODO(sergeygs): Remove this and update includes once url_handlers are
+  // moved out of experimental.
+  if (!CommandLine::ForCurrentProcess()->HasSwitch(
+      extensions::switches::kEnableExperimentalExtensionApis))

[not at google - send to devlin, 2013/09/03 18:28:04]

this seems unnecessary. Firstly you're gating this on being in dev channel not
experimental APIs. secondly try to only have a single place where features are
turned on/off. That place is at manifest parsing time.

[sergeygs, 2013/09/04 03:29:17]

This switch was only temporary (for debugging). Removed in the next patch.

+    return false;
+
+  // Limit redirection to top-level frames only.
+  if (frame != frame->top())
+    return false;
+
+  // Exclude reloads (shouldn't happen anyway) and back/forward.
+  bool navigation_type_ok =
+      WebKit::WebUserGestureIndicator::isProcessingUserGesture() ||
+      (type == WebKit::WebNavigationTypeLinkClicked) ||
+      (((type == WebKit::WebNavigationTypeFormSubmitted) ||
+        (type == WebKit::WebNavigationTypeFormResubmitted) ||
+        (type == WebKit::WebNavigationTypeOther)
+       ) && frame->opener()
+      );
+
+  if (!navigation_type_ok)
+     return false;
+
+  // Get the top-level RenderView (tab or extension window) so that we can send
+  // a routed IPC message to the correct observer.
+  content::RenderView* render_view = frame->opener() ?
+      content::RenderView::FromWebView(frame->opener()->view()) :
+      content::RenderView::FromWebView(frame->view());
+  if (!render_view)
+    return false;
+
+  // Find out if there is an extension that can handle the URL, and if there is,
+  // send an IPC to the render view to launch it.
+  const GURL url(request.url());
+  const ExtensionSet* exts = extension_dispatcher_->extensions();
+  for (ExtensionSet::const_iterator iter = exts->begin();
+       iter != exts->end();
+       ++iter) {
+    if (extensions::UrlHandlers::CanExtensionHandleUrl(*iter, url)) {
+      const GURL referrer_url(
+          request.httpHeaderField(WebString::fromUTF8("Referer")));
+      return RenderThread::Get()->Send(
+          new ExtensionHostMsg_RedirectUrl(
+              render_view->GetRoutingID(), url, referrer_url));
+    }
+  }
+
+  return false;
+}
+
 bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,
                                              const GURL& url,
                                              const std::string& http_method,
                                              bool is_initial_navigation,
                                              bool is_server_redirect,
                                              bool* send_referrer) {
   DCHECK(!frame->parent());
 
   // If this is the Instant process, fork all navigations originating from the
   // renderer.  The destination page will then be bucketed back to this Instant
@@ skipping 362 matching lines @@
 #endif  // !defined(OS_ANDROID)
   return false;
 }
 
 bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
     const base::string16& source) const {
   return extensions::IsSourceFromAnExtension(source);
 }
 
 }  // namespace chrome