Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/resources/settings/route.js

Issue 2384693004: Show "Detailed build info" subpage in About (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('settings', function() { 5 cr.define('settings', function() {
6 /** 6 /**
7 * Class for navigable routes. May only be instantiated within this file. 7 * Class for navigable routes. May only be instantiated within this file.
8 * @constructor 8 * @constructor
9 * @param {string} path 9 * @param {string} path
10 * @private 10 * @private
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 r.CUPS_PRINTER_DETAIL = r.CUPS_PRINTERS.createChild('/cupsPrinterDetails'); 192 r.CUPS_PRINTER_DETAIL = r.CUPS_PRINTERS.createChild('/cupsPrinterDetails');
193 </if> 193 </if>
194 194
195 r.ACCESSIBILITY = r.ADVANCED.createSection('/accessibility', 'a11y'); 195 r.ACCESSIBILITY = r.ADVANCED.createSection('/accessibility', 'a11y');
196 r.MANAGE_ACCESSIBILITY = r.ACCESSIBILITY.createChild('/manageAccessibility'); 196 r.MANAGE_ACCESSIBILITY = r.ACCESSIBILITY.createChild('/manageAccessibility');
197 197
198 r.SYSTEM = r.ADVANCED.createSection('/system', 'system'); 198 r.SYSTEM = r.ADVANCED.createSection('/system', 'system');
199 r.RESET = r.ADVANCED.createSection('/reset', 'reset'); 199 r.RESET = r.ADVANCED.createSection('/reset', 'reset');
200 200
201 <if expr="chromeos"> 201 <if expr="chromeos">
202 r.INPUT_METHODS = r.LANGUAGES.createChild('/inputMethods'); 202 // "About" is the only section in About, but we still need to create the route
tommycli 2016/09/30 21:04:30 Should INPUT_METHODS actually be gone?
michaelpg 2016/09/30 21:07:15 it's a dupe (from above)
203 r.DETAILED_BUILD_INFO = r.ABOUT.createChild('/help/details'); 203 // in order to show the subpage on Chrome OS.
204 r.DETAILED_BUILD_INFO.section = 'about'; 204 r.ABOUT_ABOUT = r.ABOUT.createSection('/help/about', 'about');
205 r.DETAILED_BUILD_INFO = r.ABOUT_ABOUT.createChild('/help/details');
205 </if> 206 </if>
206 207
207 var routeObservers_ = new Set(); 208 var routeObservers_ = new Set();
208 209
209 /** @polymerBehavior */ 210 /** @polymerBehavior */
210 var RouteObserverBehavior = { 211 var RouteObserverBehavior = {
211 /** @override */ 212 /** @override */
212 attached: function() { 213 attached: function() {
213 assert(!routeObservers_.has(this)); 214 assert(!routeObservers_.has(this));
214 routeObservers_.add(this); 215 routeObservers_.add(this);
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 RouteObserverBehavior: RouteObserverBehavior, 355 RouteObserverBehavior: RouteObserverBehavior,
355 getRouteForPath: getRouteForPath, 356 getRouteForPath: getRouteForPath,
356 initializeRouteFromUrl: initializeRouteFromUrl, 357 initializeRouteFromUrl: initializeRouteFromUrl,
357 getCurrentRoute: getCurrentRoute, 358 getCurrentRoute: getCurrentRoute,
358 getQueryParameters: getQueryParameters, 359 getQueryParameters: getQueryParameters,
359 lastRouteChangeWasPopstate: lastRouteChangeWasPopstate, 360 lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
360 navigateTo: navigateTo, 361 navigateTo: navigateTo,
361 navigateToPreviousRoute: navigateToPreviousRoute, 362 navigateToPreviousRoute: navigateToPreviousRoute,
362 }; 363 };
363 }); 364 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698